1160428 - Memory leak in DOMCameraControlListener::OnTakePictureComplete::Callback

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Andrew McCreight [:mccr8]]

Coverity identified this memory leak.  mData is allocated in the ctor of Callback, but never freed.

Comment 1

[Eric Rahm [:erahm]]

(In reply to Andrew McCreight (awayish through 5/5) [:mccr8] from comment #0)
> Coverity identified this memory leak.  mData is allocated in the ctor of
> Callback, but never freed.

It looks like it would only be leaked in the case the |RunCallback| is not hit. If you dig far enough you can see the memory is taken by a |DataOwner| [1] if |RunCallback| is called.

Probably the simplest solution is to free in a dtor and null out the pointer in RunCallback when transferring ownership.

[1] https://hg.mozilla.org/mozilla-central/annotate/7723b15ea695/dom/base/File.h#l530

Comment 2

[royang51]

Attachment: bug1160428.patch, V1

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8600593 [details] [diff] [review]
bug1160428.patch, V1

Review of attachment 8600593 [details] [diff] [review]:
-----------------------------------------------------------------

Conditional r+. When you reattach, append "[carries r=aosmond]" to the description and set the review+ flag.

::: dom/camera/DOMCameraControlListener.cpp
@@ +367,5 @@
>        aDOMCameraControl->OnTakePictureComplete(picture);
> +      mData = NULL;
> +    }
> +
> +    ~Callback()

The destructor should be protected and virtual.

Comment 4

[royang51]

Attachment: bug1160428.patch, V2 [carries r=aosmond]

Comment 5

[royang51]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebbb1b526848

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/995db217fd1b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/995db217fd1b