Closed Bug 1160450 Opened 5 years ago Closed 5 years ago

Places Maintenance telemetry is completely bogus and maintenance never runs

Categories

(Toolkit :: Places, defect)

defect
Not set
Points:
2

Tracking

()

RESOLVED FIXED
mozilla40
Iteration:
40.3 - 11 May
Tracking Status
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file, 1 obsolete file)

I was wondering from some time why our maintenance telemetry was reporting 100% success when we instead got bug reports that it could have solved.
Now I found why, we are setting places.database.lastMaintenance for any task in PlacesDBUtils. That also includes telemetry report that happens daily. So we basically never run it :(
This is quite bad.
Flags: qe-verify-
Flags: firefox-backlog+
Summary: Places Maintenance telemetry is completely bogus → Places Maintenance telemetry is completely bogus and maintenance never runs
Attached patch patch v1 (obsolete) — Splinter Review
Attachment #8600246 - Flags: review?(ttaubert)
Comment on attachment 8600246 [details] [diff] [review]
patch v1

Review of attachment 8600246 [details] [diff] [review]:
-----------------------------------------------------------------

Should we add another check to ensure the pref is *not* touched when running other tasks?
Attachment #8600246 - Flags: review?(ttaubert) → review+
Attached patch patch v1.1Splinter Review
Sure, I added it for the telemetry task (we don't run all the tasks, some are there just as utils for the console.
Attachment #8600246 - Attachment is obsolete: true
Iteration: --- → 40.3 - 11 May
https://hg.mozilla.org/mozilla-central/rev/fe7300d84cd6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment on attachment 8600248 [details] [diff] [review]
patch v1.1

Approval Request Comment
[Feature/regressing bug #]: old bug
[User impact if declined]: we are not running anymore maintenance on the users databases. Maintenance can resolve a lot of common issues with Places, that are usually reported as bugs.
[Describe test coverage new/current, TreeHerder]: unit test
[Risks and why]: low risk, this only moves setting a pref
[String/UUID change made/needed]: none
Attachment #8600248 - Flags: approval-mozilla-aurora?
Comment on attachment 8600248 [details] [diff] [review]
patch v1.1

Approved for uplift to aurora, in the interests of avoiding bogosity.
Attachment #8600248 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Blocks: 1163972
You need to log in before you can comment on or make changes to this bug.