Closed Bug 1160468 Opened 9 years ago Closed 9 years ago

Remove unnecessary pre-barrier when creating undepended string

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

Currently there is a comment in JSDependentString::undependInternal() that says "We destroy the base() pointer in undepend, so we need a pre-barrier."

We don't destroy the base pointer, we keep it so that we can mark it.  This comment is wrong and the barrier is unnecessary.  We should remove both.
Here's a patch.  Tested on try and it didn't break anything.
Attachment #8601421 - Flags: review?(terrence)
Comment on attachment 8601421 [details] [diff] [review]
bug1160468-undepend

Review of attachment 8601421 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8601421 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/3d2d5ade77a2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.