Cloud tabs header should be single element and heading for accessibility

RESOLVED FIXED

Status

()

Firefox for iOS
Home screen
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Boris Dušek, Assigned: Boris Dušek)

Tracking

({access})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/600.5.17 (KHTML, like Gecko) Version/8.0.5 Safari/600.5.17

Steps to reproduce:

1. Tap location label
2. Tap "Cloud tabs" button
3. Turn on VoiceOver
4. Put VoiceOver cursor on a header item (e.g. "Boris' Firefox on <device>")


Actual results:

VoiceOver read just the main title of the cell.
When I moved VoiceOver cursor to the next element, the next element was "last synced : ..."
VoiceOver did not announce that the cell is a heading, so quick navigation to next heading by VoiceOver rotor was not possible


Expected results:

VoiceOver would read the whole contents of the cell at once.
VoiceOver would announce the cell is a heading and allow quick navigation directly between these headings using VoiceOver rotor.
(Assignee)

Updated

3 years ago
Blocks: 1152335
(Assignee)

Comment 1

3 years ago
Created attachment 8600260 [details]
Screenshot: Unable to assign myself to bug

Please how do I assign myself to this bug? (see the screenshot, situation after clicking the value right to the "Assigned To:" field)
Flags: needinfo?(bnicholson)

Comment 2

3 years ago
It's all yours. No need to ask :)
Assignee: nobody → dusek
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(bnicholson)
Keywords: access
(Assignee)

Comment 3

3 years ago
To not have to file a separate bug: Computer vs. Mobile device should also be announced (cell image)
(Assignee)

Comment 4

3 years ago
Created attachment 8600407 [details] [review]
Pull request
Attachment #8600407 - Flags: review?(sarentz)
(Assignee)

Comment 5

3 years ago
(In reply to atrain from comment #2)
> It's all yours. No need to ask :)

I was wondering how one should follow the "Assign yourself" instruction in the Contributor guidelines (README.md on GitHub) ;-)
I'm not sure why you can't assign bugs to yourself. Let me investigate.

The patch looks great. I'll merge it soon.
(Assignee)

Comment 7

3 years ago
Thanks Stefan but no need to investigate that, I applied for the "editbugs" privilege as suggested by Brian and Nick, approval is pending, until then I can't assign bugs to myself.
Added a quick comment to the patch about a println() that was left in. Other than that it should be good to go.
Merged. Thank you for the contribution.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Attachment #8600407 - Flags: review?(sarentz) → review+
You need to log in before you can comment on or make changes to this bug.