Closed
Bug 1160476
Opened 9 years ago
Closed 9 years ago
‘Bookmark this link’ context menu option doesn’t work
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox39 | --- | unaffected |
firefox40 | + | verified |
firefox41 | + | verified |
People
(Reporter: robin, Assigned: mak)
References
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
9.43 KB,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
9.52 KB,
patch
|
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:40.0) Gecko/20100101 Firefox/40.0 Build ID: 20150430030201 Steps to reproduce: Right clicked on a link, chose ‘Bookmark This Link’ Actual results: Context menu disappeared, nothing else. This error appears in the browser console: A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'? See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise Date: Fri May 01 2015 13:07:15 GMT+0100 (BST) Full Message: ReferenceError: linkURI is not defined Full Stack: PlacesCommandHook.bookmarkLink<@chrome://browser/content/browser.js:5358:42 TaskImpl_run@resource://gre/modules/Task.jsm:314:40 TaskImpl@resource://gre/modules/Task.jsm:275:3 createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14 CM_bookmarkLink@chrome://browser/content/nsContextMenu.js:1558:1 oncommand@chrome://browser/content/browser.xul:1:1 Expected results: A bookmark to that link would appear in the Bookmarks / Recently Bookmarked menu.
Reporter | ||
Updated•9 years ago
|
Component: Untriaged → Bookmarks & History
Comment 1•9 years ago
|
||
Just hit this, I think it's fallout from bug 951651.
Blocks: 951651
Status: UNCONFIRMED → NEW
status-firefox40:
--- → affected
Ever confirmed: true
Flags: needinfo?(mano)
Flags: needinfo?(mak77)
Keywords: regression
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Flags: needinfo?(mak77)
Assignee | ||
Updated•9 years ago
|
Points: --- → 2
Flags: qe-verify+
Flags: needinfo?(mano)
Flags: firefox-backlog+
Assignee | ||
Comment 2•9 years ago
|
||
this is just missing a yield... I actually had this fixed already in bug 1094818, but I'll split the fix here to allow for a quicker review.
Points: 2 → 1
Assignee | ||
Comment 3•9 years ago
|
||
well, not just the yield, linkURI is in the wrong scope and we can simplify the code.
Updated•9 years ago
|
Iteration: --- → 40.3 - 11 May
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8603566 -
Flags: review?(ttaubert)
Assignee | ||
Comment 5•9 years ago
|
||
I likely need to unbitrot this against Bug 1135619
Assignee | ||
Comment 6•9 years ago
|
||
Unbitrotted patch
Attachment #8603566 -
Attachment is obsolete: true
Attachment #8603566 -
Flags: review?(ttaubert)
Attachment #8605306 -
Flags: review?(ttaubert)
Assignee | ||
Comment 7•9 years ago
|
||
[Tracking Requested - why for this release]: recent regression, broken functionality
status-firefox39:
--- → unaffected
tracking-firefox40:
--- → ?
Updated•9 years ago
|
status-firefox41:
--- → affected
Since this is a recent regression and affects both firefox40 & firefox 41, adding tracking flags for firefox40 and firefox41.
tracking-firefox41:
--- → +
Updated•9 years ago
|
Iteration: 40.3 - 11 May → 41.1 - May 25
Updated•9 years ago
|
Attachment #8605306 -
Flags: review?(ttaubert) → review+
Assignee | ||
Comment 10•9 years ago
|
||
I'm preparing the Aurora version of the patch, will ask for approval on that.
Assignee | ||
Comment 11•9 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: bug 951651 [User impact if declined]: Bookmark this link contextual menu doesn't work [Describe test coverage new/current, TreeHerder]: Nightly, manual testing [Risks and why]: low risk since reusing existing code path [String/UUID change made/needed]: none
Attachment #8608162 -
Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/4db392b8bed0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment 13•9 years ago
|
||
Comment on attachment 8608162 [details] [diff] [review] aurora patch v1 Recent regression, taking it.
Attachment #8608162 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•