Closed Bug 1160485 Opened 6 years ago Closed 6 years ago

remove implicit conversion from RefPtr<T> to TemporaryRef<T>

Categories

(Core :: MFBT, defect)

Product:
Core
Component:
MFBT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

remove implicit conversion from RefPtr<T> to TemporaryRef<T>
59.41 KB, patch
ehsan
: review+
Details | Diff | Splinter Review 
Having this implicit conversion means that we can silently do extra
refcounting when it's completely unnecessary.  It's also an obstacle to
making RefPtr more nsRefPtr-like, so let's get rid of it.
It's a little depressing how much code had to be modified to make this work.
Attachment #8600302 - Flags: review?(ehsan)
Comment on attachment 8600302 [details] [diff] [review]
remove implicit conversion from RefPtr<T> to TemporaryRef<T>

Review of attachment 8600302 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this!
Attachment #8600302 - Flags: review?(ehsan) → review+
Blocks: 1161627
https://hg.mozilla.org/mozilla-central/rev/e9b68252df54
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.