remove implicit conversion from RefPtr<T> to TemporaryRef<T>

RESOLVED FIXED in Firefox 41

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

Having this implicit conversion means that we can silently do extra
refcounting when it's completely unnecessary.  It's also an obstacle to
making RefPtr more nsRefPtr-like, so let's get rid of it.
It's a little depressing how much code had to be modified to make this work.
Attachment #8600302 - Flags: review?(ehsan)
Comment on attachment 8600302 [details] [diff] [review]
remove implicit conversion from RefPtr<T> to TemporaryRef<T>

Review of attachment 8600302 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this!
Attachment #8600302 - Flags: review?(ehsan) → review+
Blocks: 1161627
https://hg.mozilla.org/mozilla-central/rev/e9b68252df54
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.