1160521 - The markers list sidebar should be wider by default

Status: VERIFIED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Comment 1

[Victor Porof [:vporof][:vp]]

Splitting this into two bugs, since making it resizable requires a more destructive rewrite. The reason for this is that the "sidebar" isn't actually a sidebar, but a node inside a row-like structure that's always the same width and has a right border.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8604698 [details] [diff] [review]
v1

Review of attachment 8604698 [details] [diff] [review]:
-----------------------------------------------------------------

Good call on making it resizable

Comment 4

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/d20045f6280b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d20045f6280b

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8604698 [details] [diff] [review]
v1


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None

Comment 7

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2346b4e5b5bb

Comment 8

[Brian Grinstead [:bgrins]]

Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8604698 [details] [diff] [review]
v1

Change approved to skip one train as part of the spring campaign.

Comment 10

[Andrei Vaida [:avaida]]

Verified fixed on Aurora 40.0a2 (2015-06-08), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.

Compared to older/affected builds, the marker sidebar's width is now larger, showing data in a more reasonable way.