Closed
Bug 1160521
Opened 9 years ago
Closed 9 years ago
The markers list sidebar should be wider by default
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox40 verified, firefox41 fixed)
VERIFIED
FIXED
Firefox 41
People
(Reporter: vporof, Assigned: vporof)
References
Details
Attachments
(1 file)
871 bytes,
patch
|
jsantell
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P2
Assignee | ||
Comment 1•9 years ago
|
||
Splitting this into two bugs, since making it resizable requires a more destructive rewrite. The reason for this is that the "sidebar" isn't actually a sidebar, but a node inside a row-like structure that's always the same width and has a right border.
Summary: The markers list sidebar should be resizable and wider by default → The markers list sidebar should be wider by default
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8604698 -
Flags: review?(jsantell)
Comment 3•9 years ago
|
||
Comment on attachment 8604698 [details] [diff] [review] v1 Review of attachment 8604698 [details] [diff] [review]: ----------------------------------------------------------------- Good call on making it resizable
Attachment #8604698 -
Flags: review?(jsantell) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d20045f6280b
Whiteboard: [fixed-in-fx-team]
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d20045f6280b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Updated•9 years ago
|
Blocks: perf-40-uplifts
Updated•9 years ago
|
Flags: qe-verify+
Comment 6•9 years ago
|
||
Comment on attachment 8604698 [details] [diff] [review] v1 Approval Request Comment [Feature/regressing bug #]: 1167252, the new performance tool [User impact if declined]: Won't ship the performance tool [Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift [Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake. Risks are generally contained within devtools, specifically within the performance panel. [String/UUID change made/needed]: None
Attachment #8604698 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/2346b4e5b5bb
status-firefox40:
--- → fixed
Comment 8•9 years ago
|
||
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+. See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment 9•9 years ago
|
||
Comment on attachment 8604698 [details] [diff] [review] v1 Change approved to skip one train as part of the spring campaign.
Attachment #8604698 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•9 years ago
|
||
Verified fixed on Aurora 40.0a2 (2015-06-08), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5. Compared to older/affected builds, the marker sidebar's width is now larger, showing data in a more reasonable way.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•