The markers list sidebar should be wider by default

VERIFIED FIXED in Firefox 40

Status

P2
normal
VERIFIED FIXED
3 years ago
3 months ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 41
Dependency tree / graph

Firefox Tracking Flags

(firefox40 verified, firefox41 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P2
(Assignee)

Comment 1

3 years ago
Splitting this into two bugs, since making it resizable requires a more destructive rewrite. The reason for this is that the "sidebar" isn't actually a sidebar, but a node inside a row-like structure that's always the same width and has a right border.
Summary: The markers list sidebar should be resizable and wider by default → The markers list sidebar should be wider by default
(Assignee)

Comment 2

3 years ago
Created attachment 8604698 [details] [diff] [review]
v1
Attachment #8604698 - Flags: review?(jsantell)
Comment on attachment 8604698 [details] [diff] [review]
v1

Review of attachment 8604698 [details] [diff] [review]:
-----------------------------------------------------------------

Good call on making it resizable
Attachment #8604698 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/d20045f6280b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Blocks: 1167252
Flags: qe-verify+
Comment on attachment 8604698 [details] [diff] [review]
v1


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None
Attachment #8604698 - Flags: approval-mozilla-aurora?
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment on attachment 8604698 [details] [diff] [review]
v1

Change approved to skip one train as part of the spring campaign.
Attachment #8604698 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on Aurora 40.0a2 (2015-06-08), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.

Compared to older/affected builds, the marker sidebar's width is now larger, showing data in a more reasonable way.
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
Flags: qe-verify+

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.