1160545 - crash-submission-succeeded counts seem to be buggy

Status: RESOLVED WORKSFORME

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[(not currently active) Ted Mielczarek]

I was looking at my raw FHR data, and every single crashes record looks like this:
        "org.mozilla.crashes.crashes": {
          "_v": 6,
          "content-crash": 1,
          "content-crash-submission-succeeded": 11,
          "main-crash": 1,
          "main-crash-submission-succeeded": 11
        },

I suspect there's a string coercion bug somewhere in the code, but I can't spot it from reading the code. Every single one of the -succeded values is 11, which makes me think something is doing "1" + 1.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Given that this is a minor bug and that we are currently moving over from the FHR implementation to (unified) Telemetry, i don't think we care about this.

Comment 2

[(not currently active) Ted Mielczarek]

The new data will be exposed once bug 1121013 sticks? I'm not entirely sure where this bug exists, so it's possible it's in the data collection itself and it'll exist in Telemetry as well.

Comment 3

[Gregory Szorc [:gps]]

Brendan: I don't suppose you've seen any wonky crash stats data that this bug could be responsible for, have you?

Comment 4

[brendan c]

I haven't noticed anything, but I haven't looked at anything related in while. May be worth pinging fhr-dev.

Comment 5

[Georg Fritzsche [:gfritzsche]]

FHR is going away per bug 1209088, closing.