1160566 - Make FrameMetrics::mCompositionBounds private

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Last one, time to finish this off. Note that the attached patch applies on top of the patches from bug 1160250. Try push shows a clean build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=87ee17824b1c

Comment 1

[Botond Ballo [:botond]]

Comment on attachment 8600379 [details] [diff] [review]
Patch

Review of attachment 8600379 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks for finishing this off!

::: gfx/layers/FrameMetrics.h
@@ +254,5 @@
> +  {
> +    mCompositionBounds = aCompositionBounds;
> +  }
> +
> +  ParentLayerRect GetCompositionBounds() const

Hmm, I noticed at some point we started writing getters that return structures by value rather than by reference-to-const (for example, GetViewport() returns by reference-to-const, but GetDisplayPort() doesn't). 

I would prefer returning by reference-to-const here, and fixing the others in a follow-up.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Private-ize mCompositionBounds

Updated to return const-ref, carrying r+

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Update other getters to return const-ref

Pretty trivial change

Comment 4

[Botond Ballo [:botond]]

Comment on attachment 8600461 [details] [diff] [review]
Part 2 - Update other getters to return const-ref

Review of attachment 8600461 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c780203cf304
https://hg.mozilla.org/integration/mozilla-inbound/rev/bec29299cb7e

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c780203cf304
https://hg.mozilla.org/mozilla-central/rev/bec29299cb7e