Talos regressions due to browser.reader.detectedFirstArticle not being set to True

RESOLVED FIXED in Firefox 39

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: MattN, Assigned: MattN)

Tracking

unspecified
mozilla40
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox39 fixed, firefox40 fixed)

Details

()

Attachments

(3 attachments)

The pref browser.reader.detectedFirstArticle needs to be set to True on Talos so that the info panel doesn't appear on the first reader-friendly page.

I did this for prefs_general but unfortunately that doesn't affect Talos: 
https://hg.mozilla.org/integration/fx-team/diff/6404e6d64787/testing/profiles/prefs_general.js

Push: https://hg.mozilla.org/integration/fx-team/pushloghtml?changeset=b4fd9967aa85

This will have to be uplifted to 38.0.5 since that's where bug 134507 is ending up.
Flags: firefox-backlog+
Comment on attachment 8600397 [details] [diff] [review]
v.1 Add browser.reader.detectedFirstArticle =  True

Review of attachment 8600397 [details] [diff] [review]:
-----------------------------------------------------------------

we might have to be careful on getting this updated talos on aurora/beta- but lets get it on trunk and work our way down the line!
Attachment #8600397 - Flags: review?(jmaher) → review+
Pushed: https://hg.mozilla.org/build/talos/rev/c1da803b295e

Do you want to file a new bug for deployment and resolve this one or do you want to deal with deployment here?
yeah, lets just add a trunk patch for testing/talos/talos.json, it is just a minor rev  bump!

Updated

4 years ago
No longer blocks: 134507
Duplicate of this bug: 1161073
(In reply to Joel Maher (:jmaher) from comment #4)
> yeah, lets just add a trunk patch for testing/talos/talos.json, it is just a
> minor rev  bump!

Is that something you are going to do? Or did you want me to?
Flags: needinfo?(jmaher)
Flags: needinfo?(jmaher)
Attachment #8600992 - Flags: review?(MattN+bmo)
Attachment #8600992 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/485f28832a3a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
going to land on aurora.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8601519 - Flags: review?(wlachance) → review+
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.