Closed
Bug 1160621
Opened 9 years ago
Closed 9 years ago
Option collection model in frontend could be more convenient to use
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file)
Every time we use the option collection model, we do the exact same transformation to turn the results of get_list into a map. This is perhaps a sign that we should provide a convenience method to do this up front. :)
|
Assignee | |
Comment 1•9 years ago
|
||
Hopefully self explanatory. Note that I fixed up the formatting in option_collection.js to match the rest of treeherder (except for perfherder, but we'll fix that somewhere else).
Attachment #8600435 -
Flags: review?(cdawson)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8600435 [details] [review] PR Looks good to me. :)
Attachment #8600435 -
Flags: review?(cdawson) → review+
|
||
Comment 3•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/b2aa6eabfb576eabc0fa9c66d302df2433f82639 Bug 1160621 - Provide a better method for getting option collection map
|
|
||
Comment 4•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/608603c546fcd8dfd249a315f1bb3b60e48dd056 Bug 1160621 - Provide a better method for getting option collection map
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•