Option collection model in frontend could be more convenient to use

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Details

Attachments

(1 attachment)

Every time we use the option collection model, we do the exact same transformation to turn the results of get_list into a map. This is perhaps a sign that we should provide a convenience method to do this up front. :)
Created attachment 8600435 [details] [review]
PR

Hopefully self explanatory. Note that I fixed up the formatting in option_collection.js to match the rest of treeherder (except for perfherder, but we'll fix that somewhere else).
Attachment #8600435 - Flags: review?(cdawson)
Comment on attachment 8600435 [details] [review]
PR

Looks good to me.  :)
Attachment #8600435 - Flags: review?(cdawson) → review+

Comment 4

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/608603c546fcd8dfd249a315f1bb3b60e48dd056
Bug 1160621 - Provide a better method for getting option collection map
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.