Closed Bug 1160623 Opened 9 years ago Closed 9 years ago

[Customizer] Fix script editor papercuts/visual design

Categories

(Firefox OS Graveyard :: Gaia::Customizer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Customizer
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

Attachments

(1 file)

pull-request (master)
42 bytes, text/x-github-pull-request
drs
: review+
Details | Review 
The recently-landed script editor did not have proper colors applied from UX. Need to apply the following colors as well as fix some previously mentioned papercuts (validation timing, scrolling past error message).

line numbers: #95368c
error message: #e51e1e
Assignee: nobody → jdarcangelo
Blocks: spark-customizer
Attached file pull-request (master) — 
Applied proper CSS colors from amylee. Also tried improving some of the timing around the JS validation as well as fixing the ability to scroll to the bottom line when an error message is displayed.
Attachment #8600430 - Flags: review?(drs)
Comment on attachment 8600430 [details] [review]
pull-request (master)

Looks good. I left one comment on the PR.
Attachment #8600430 - Flags: review?(drs) → review+
Addressed review comment.

Landed on master:

https://github.com/fxos/customizer/commit/8a85f3457716923236ff1627890371d174c1b0cd
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: