[Customizer] Fix script editor papercuts/visual design

RESOLVED FIXED

Status

Firefox OS
Gaia::Customizer
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: justindarc, Assigned: justindarc)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The recently-landed script editor did not have proper colors applied from UX. Need to apply the following colors as well as fix some previously mentioned papercuts (validation timing, scrolling past error message).

line numbers: #95368c
error message: #e51e1e
(Assignee)

Updated

3 years ago
Assignee: nobody → jdarcangelo
Blocks: 1133943
(Assignee)

Comment 1

3 years ago
Created attachment 8600430 [details] [review]
pull-request (master)

Applied proper CSS colors from amylee. Also tried improving some of the timing around the JS validation as well as fixing the ability to scroll to the bottom line when an error message is displayed.
Attachment #8600430 - Flags: review?(drs)
Comment on attachment 8600430 [details] [review]
pull-request (master)

Looks good. I left one comment on the PR.
Attachment #8600430 - Flags: review?(drs) → review+
(Assignee)

Comment 3

3 years ago
Addressed review comment.

Landed on master:

https://github.com/fxos/customizer/commit/8a85f3457716923236ff1627890371d174c1b0cd
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.