Closed Bug 1160650 Opened 4 years ago Closed 4 years ago

Update copy of mozprocess in mozharness

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set

Tracking

(firefox40 fixed)

RESOLVED FIXED
Tracking Status
firefox40 --- fixed

People

(Reporter: ahal, Assigned: cmanchester)

Details

Attachments

(2 files, 2 obsolete files)

The copy of mozprocess kept in mozharness is at revision 0.15, in other words, hasn't been updated since January 2014. There have been a lot of fixes and improvements to mozprocess in the meantime.

Also, it is still affected by bug 950894, which means if you run a mozharness script with python >2.7.6, you'll hit an error.

At the very least we should cherry pick the patch from bug 950894, but we'll need to do this anyway as part of moving mozharness in-tree, so might as well get it over with.
(In reply to Andrew Halberstadt [:ahal] from comment #0) 
> Also, it is still affected by bug 950894, which means if you run a
> mozharness script with python >2.7.6, you'll hit an error.

* on windows
/r/8063 - Bug 1160650 - Backport bug 950894 to mozharness' version of mozprocess to avoid the issue for those running mozharness on windows with python >= 2.7.6

Pull down this commit:

hg pull -r 2941e9952f703a6822773ce93d0c0302ef97897f https://reviewboard-hg.mozilla.org/build-mozharness
Comment on attachment 8600490 [details]
MozReview Request: bz://1160650/chmanchester

Here's the backport patch, which should be safest. I'd guess this is a problem for pretty much anyone trying to use mozharness locally on windows, so maybe worth getting in. :maja_zf, does this patch fix the issue you encountered?
Attachment #8600490 - Flags: feedback?(mjzffr)
Comment on attachment 8600490 [details]
MozReview Request: bz://1160650/chmanchester

Yep! Verified.
Attachment #8600490 - Flags: feedback?(mjzffr) → feedback+
Comment on attachment 8600490 [details]
MozReview Request: bz://1160650/chmanchester

Here's a band-aid for windows users. We don't really need to take this if we're ready to do a more extensive upgrade immediately, but enough has changed in mozprocess recently I would be surprised if its trivial.
Attachment #8600490 - Flags: review?(ahalberstadt)
Comment on attachment 8600490 [details]
MozReview Request: bz://1160650/chmanchester

/r/8063 - Bug 1160650 - Backport bug 950894 to mozharness' version of mozprocess to avoid the issue for those running mozharness on windows with python >= 2.7.6

Pull down this commit:

hg pull -r 2941e9952f703a6822773ce93d0c0302ef97897f https://reviewboard-hg.mozilla.org/build-mozharness
Attachment #8600490 - Flags: feedback+
Comment on attachment 8600490 [details]
MozReview Request: bz://1160650/chmanchester

https://reviewboard.mozilla.org/r/8061/#review6867

Ship It!
Attachment #8600490 - Flags: review?(ahalberstadt) → review+
This patch updates to the most recent commit on production.
Attachment #8601536 - Flags: review?(armenzg)
Assignee: nobody → cmanchester
Status: NEW → ASSIGNED
Already bitrotted (but not recent on enough!).
Attachment #8601581 - Flags: review?(armenzg)
Attachment #8601536 - Attachment is obsolete: true
Attachment #8601536 - Flags: review?(armenzg)
Attachment #8601581 - Flags: review?(armenzg) → review+
https://hg.mozilla.org/mozilla-central/rev/7e195d8623ec
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Attachment #8600490 - Attachment is obsolete: true
Attachment #8620219 - Flags: review+
You need to log in before you can comment on or make changes to this bug.