1160661 - [email] use gaia-theme.css to get transition-duration CSS variable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[James Burke [:jrburke]]

Bug 1143226 introduced a shorter animation direction, but uses a css variable from gaia-theme.css. Email should include that css file, so that it works.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] jrburke:bug1160661-email-gaia-theme-css > mozilla-b2g:master

Comment 2

[James Burke [:jrburke]]

Comment on attachment 8600483 [details] [review]
[gaia] jrburke:bug1160661-email-gaia-theme-css > mozilla-b2g:master

r+ from :asuth in IRC, where the fix was shared.

Comment 3

[:gerard-majax]

Comment on attachment 8600483 [details] [review]
[gaia] jrburke:bug1160661-email-gaia-theme-css > mozilla-b2g:master

Applied locally, and it fixed the regression for me.

Comment 4

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/2c1df1da6184d6f3ff875f24aeb3273f7d93d222

Comment 5

[Dale Harvey (:daleharvey)]

This seems like something that should have been caught in the test suite, can we do anything to make sure this doesnt happen again?

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Yes, this should have been caught by integration tests, which is my fault, one of my Q2 goals, and tracked on bug 975588.  (There's been a history of cost/benefit triages.)

But I do need to call out that the patch that caused this regression was changed after it was reviewed by jrburke, so it's also important to re-request review when making changes to a patch.  Our revised integration test coverage will be good, but not so good that you can land unreviewed code.