Closed Bug 1160661 Opened 8 years ago Closed 8 years ago

[email] use gaia-theme.css to get transition-duration CSS variable

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jrburke, Assigned: jrburke)

References

Details

Attachments

(1 file)

Bug 1143226 introduced a shorter animation direction, but uses a css variable from gaia-theme.css. Email should include that css file, so that it works.
Comment on attachment 8600483 [details] [review]
[gaia] jrburke:bug1160661-email-gaia-theme-css > mozilla-b2g:master

r+ from :asuth in IRC, where the fix was shared.
Attachment #8600483 - Flags: review+
Keywords: checkin-needed
Comment on attachment 8600483 [details] [review]
[gaia] jrburke:bug1160661-email-gaia-theme-css > mozilla-b2g:master

Applied locally, and it fixed the regression for me.
Attachment #8600483 - Flags: feedback+
Depends on: fastandfurious
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
This seems like something that should have been caught in the test suite, can we do anything to make sure this doesnt happen again?
Flags: needinfo?(jrburke)
Yes, this should have been caught by integration tests, which is my fault, one of my Q2 goals, and tracked on bug 975588.  (There's been a history of cost/benefit triages.)

But I do need to call out that the patch that caused this regression was changed after it was reviewed by jrburke, so it's also important to re-request review when making changes to a patch.  Our revised integration test coverage will be good, but not so good that you can land unreviewed code.
Flags: needinfo?(jrburke)
You need to log in before you can comment on or make changes to this bug.