Closed
Bug 1160689
Opened 10 years ago
Closed 10 years ago
thumbnail image corruption on certain videos
Categories
(Core :: Audio/Video, defect)
Tracking
()
People
(Reporter: diego, Assigned: diego)
References
Details
(Whiteboard: [caf priority: p2][CR 812421])
Attachments
(1 file, 1 obsolete file)
2.11 KB,
patch
|
diego
:
review+
kkuo
:
approval-mozilla-b2g37+
|
Details | Diff | Splinter Review |
STR:
1. upload a QCIF MPEG4 video file
2. Open video app
Result: the thumbnail video is scrambled
I can only reproduce on a prototype Lollipop device, but I have a patch that I'm attaching.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8600516 -
Flags: review?(sotaro.ikeda.g)
Updated•10 years ago
|
Whiteboard: [CR 812421] → [caf priority: p2][CR 812421]
Comment 2•10 years ago
|
||
Comment on attachment 8600516 [details] [diff] [review]
Query stride when converting HAL_PIXEL_FORMAT_YCrCb_420_SP
Review of attachment 8600516 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good!
Attachment #8600516 -
Flags: review?(sotaro.ikeda.g) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Format patch for HG and carry over r=sotaro
Attachment #8601168 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Attachment #8600516 -
Attachment is obsolete: true
Comment 4•10 years ago
|
||
can we get a try run for this changes, thanks!
Flags: needinfo?(dwilson)
Keywords: checkin-needed
Updated•10 years ago
|
Status: NEW → ASSIGNED
blocking-b2g: 2.2? → 2.2+
Comment 5•10 years ago
|
||
Hi! Diego,
Please file approval‑mozilla‑b2g37 before checkin.
Thanks
--
Keven
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8601168 [details] [diff] [review]
Query stride when converting HAL_PIXEL_FORMAT_YCrCb_420_SP
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 961713
User impact if declined: The thumbnails of certain H.264 videos will be scrambled
Testing completed: Verified the thumbnails of videos look correctly in FxOS video app
Risk to taking this patch (and alternatives if risky): This is a low risk patch
String or UUID changes made by this patch: None
Flags: needinfo?(dwilson)
Attachment #8601168 -
Flags: approval-mozilla-b2g37?
Updated•10 years ago
|
Attachment #8601168 -
Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
Assignee | ||
Comment 7•10 years ago
|
||
Tomcat,
Try build https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8daf6ac7801
A couple of test failures but it seems like known intermittent failures. Does it look sane to you?
Flags: needinfo?(cbook)
Comment 8•10 years ago
|
||
Comment 9•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment 10•10 years ago
|
||
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
status-firefox38:
--- → wontfix
status-firefox39:
--- → wontfix
Updated•9 years ago
|
Flags: needinfo?(cbook)
You need to log in
before you can comment on or make changes to this bug.
Description
•