Closed Bug 1160689 Opened 8 years ago Closed 8 years ago

thumbnail image corruption on certain videos

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Project Flags:
blocking-b2g 2.2+
Tracking Flags:
Tracking Status
firefox38 --- wontfix
firefox39 --- wontfix
firefox40 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: diego, Assigned: diego)

References

Details

(Whiteboard: [caf priority: p2][CR 812421])

Attachments

(1 file, 1 obsolete file)

Query stride when converting HAL_PIXEL_FORMAT_YCrCb_420_SP
2.11 KB, patch
diego
: review+
kkuo
: approval-mozilla-b2g37+
Details | Diff | Splinter Review 
STR:
1. upload a QCIF MPEG4 video file
2. Open video app

Result: the thumbnail video is scrambled

I can only reproduce on a prototype Lollipop device, but I have a patch that I'm attaching.

        Attachment #8600516 -
        Flags: review?(sotaro.ikeda.g)

    
  
blocking-b2g: --- → 2.2?
No longer depends on: 1147763
Whiteboard: [CR 812421] → [caf priority: p2][CR 812421]

    
    

    
  
Comment on attachment 8600516 [details] [diff] [review]
Query stride when converting HAL_PIXEL_FORMAT_YCrCb_420_SP

Review of attachment 8600516 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

        Attachment #8600516 -
        Flags: review?(sotaro.ikeda.g) → review+

    
    

    
  


  
Format patch for HG and carry over r=sotaro

        Attachment #8601168 -
        Flags: review+

    
  
Keywords: checkin-needed

    
  

        Attachment #8600516 -
        Attachment is obsolete: true

    
    

    
  
can we get a try run for this changes, thanks!
Flags: needinfo?(dwilson)
Keywords: checkin-needed

    
  
Status: NEW → ASSIGNED
blocking-b2g: 2.2? → 2.2+

    
    

    
  
Hi! Diego,

Please file approval‑mozilla‑b2g37 before checkin.
Thanks

--
Keven

    
    

    
  
Comment on attachment 8601168 [details] [diff] [review]
Query stride when converting HAL_PIXEL_FORMAT_YCrCb_420_SP

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 961713
User impact if declined: The thumbnails of certain H.264 videos will be scrambled
Testing completed: Verified the thumbnails of videos look correctly in FxOS video app
Risk to taking this patch (and alternatives if risky): This is a low risk patch
String or UUID changes made by this patch: None
Flags: needinfo?(dwilson)

        Attachment #8601168 -
        Flags: approval-mozilla-b2g37?

    
  

        Attachment #8601168 -
        Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+

    
    

    
  
Tomcat,

Try build https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8daf6ac7801

A couple of test failures but it seems like known intermittent failures. Does it look sane to you?
Flags: needinfo?(cbook)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/819c760b572f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox40:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Flags: needinfo?(cbook)

          You need to log in
          before you can comment on or make changes to this bug.