Closed Bug 1160708 Opened 5 years ago Closed 5 years ago

Bookmark Properties dialog not longer allows empty bookmark names

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 40
Iteration:
40.3 - 11 May
Tracking Status
firefox39 --- unaffected
firefox40 --- verified

People

(Reporter: cpeterson, Assigned: mak)

References

Details

(Keywords: regression, reproducible)

Attachments

(1 file)

I have many bookmarks with empty names on my bookmarks toolbar (so only the favicon is displayed). In Nightly 40, changing a bookmark's name to the empty string and pressing ENTER or clicking the Properties dialog's Save button will close the dialog (as expected) but leave the bookmark's name unchanged.

I bisected this regression to the following pushlog. I assume this is a regression from bug 951651.

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2f2888ca42c2&tochange=2a1ddf08a4b4
[Tracking Requested - why for this release]:

Mano, I think this bookmark name bug is a regression from bookmarkProperties work in bug 951651. See also bug 1160864.
Blocks: 1160864
Flags: needinfo?(mano)
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Points: --- → 1
Flags: qe-verify+
Flags: needinfo?(mano)
Flags: firefox-backlog+
No longer blocks: 1160864
Attached patch patch v1Splinter Review
trivial typo
Attachment #8600846 - Flags: review?(ttaubert)
Attachment #8600846 - Flags: review?(ttaubert) → review+
Iteration: --- → 40.3 - 11 May
https://hg.mozilla.org/mozilla-central/rev/7f1f30690b87
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
You need to log in before you can comment on or make changes to this bug.