Closed Bug 1160721 Opened 9 years ago Closed 5 years ago

Remove "double spacing" in SSLerrs.h and SECerrs.h strings

Categories

(NSS :: Libraries, defect, P5)

defect

Tracking

(firefox40 affected)

RESOLVED FIXED
Tracking Status
firefox40 --- affected

People

(Reporter: Cykesiopka, Assigned: manishkk)

References

()

Details

Attachments

(1 file, 2 obsolete files)

Bug 1153446 was filed on unnecessary "double spacing" in nsserrors.properties entries. It looks these double spaces were just copied over from the hard coded en-US strings in SSLerrs.h and SECerrs.h.

It's not clear to me if the double spacing in these two files is intentional, or if they are part of API and hence can't be changed. Feel free to resolve this bug as WONTFIX/INVALID etc as necessary.
Priority: -- → P5
QA Contact: franziskuskiefer
Assignee: nobody → 1991manish.kumar
Attached file Patch_BugLatest (obsolete) —
Please review.

Thanks
Attachment #9027358 - Flags: review?(franziskuskiefer)
Comment on attachment 9027358 [details]
Patch_BugLatest

1. You need to do this CL as a change against NSS, not a change against Firefox. https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS
2. CLs should be submitted using Phabricator, not Splinter.
3. You've also broken the indentation, which needs to line up with the parentheses, not be 2 spaces in. Run |./mach clang-format| before submitting.
Attachment #9027358 - Flags: review?(franziskuskiefer)
Please Ignore the patch! 
It was phabricator test.
Attachment #9029854 - Attachment is obsolete: true
Attachment #9027358 - Attachment is obsolete: true
Attachment #9027358 - Attachment is patch: false
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: