Closed
Bug 1160782
Opened 9 years ago
Closed 4 years ago
Reduce the amount of preprocessing in SeaMonkey files e.g. using AppConstants.jsm
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1588875
People
(Reporter: philip.chee, Unassigned, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=js,xul])
No description provided.
Hi Philip, Could you offer me some more detail information about this bug? Due to I'm new to Seamonkey, so I'm afraid can't start my work without your help, Thank you very much :)
Reporter | ||
Comment 2•9 years ago
|
||
We put a lot of our source code through the pre-processor, sometimes unnecessarily. The initial rationale is explained in: Bug 1093358 - Preprocess less JavaScript in mobile/android The changeset in Bug 1139958 (https://hg.mozilla.org/mozilla-central/rev/0149e6ca4cb3) should have some examples This is the Mercurial change log for AppConstants.jsm. Clicking on the "diff" links should call up various mercurial changesets touching this file. You could start by grep-ping through the /suite/ files looking for pre-processor directives that can be replaced by AppConstants.jsm e.g. /comm-central/suite/common/pref/pref-applications.js has a few pre-processor directives (e.g. #ifdef XP_WIN) that can be replaced with "normal" javascript.
Comment 3•8 years ago
|
||
Just tested the Data Manager and it's no longer able to delete form items in c-c. Is AppConstants in Seamonkey? If not this bug might need to be implemented for 2.45. Timestamp: 12/8/2015 7:14:26 PM Error: ReferenceError: AppConstants is not defined Source File: file:///C:/seabuild/release/comm-central-15/obj-x86_64-pc-mingw32/dist/bin/components/nsFormHistory.js Line: 352 Timestamp: 12/8/2015 7:14:26 PM Error: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "AppConstants is not defined" {file: "file:///C:/seabuild/release/comm-central-15/obj-x86_64-pc-mingw32/dist/bin/components/nsFormHistory.js" line: 352}]'[JavaScript Error: "AppConstants is not defined" {file: "file:///C:/seabuild/release/comm-central-15/obj-x86_64-pc-mingw32/dist/bin/components/nsFormHistory.js" line: 352}]' when calling method: [nsIFormHistory2::removeEntry] Source File: chrome://communicator/content/dataman/dataman.js Line: 2799
Comment 4•8 years ago
|
||
Opps too fast. Make that 2.42. It's FF 45.
Reporter | ||
Comment 5•8 years ago
|
||
AppConstants.jsm certainly exists in SeaMonkey. Just type resource://gre/modules/AppConstants.jsm in the urlbar and it will show up.
Reporter | ||
Comment 6•8 years ago
|
||
I filed Bug 1231839 - ReferenceError: AppConstants is not defined /dist/bin/components/nsFormHistory.js
Updated•4 years ago
|
Keywords: good-first-bug
Whiteboard: [good first bug][lang=js,xul] → [lang=js,xul]
Comment 7•4 years ago
|
||
I think we are done here already
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox40:
affected → ---
Depends on: 1588874
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•