1160799 - [Aries] youtube fullscreen has a green background

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Dale Harvey (:daleharvey)]

User-Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

I played a youtube vudeo at full screen, when rotating the bg was green, screenshot wouldnt show the green

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Which device did you test on?  (My guess would be aries)

It's hard to determine if this is a video issue in hardware or software without logs and gaia/gecko information.

Comment 2

[Dale Harvey (:daleharvey)]

Yup, aries on latest gecko / gaia

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

qawanted for confirmation of bug.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: logcat of issue

Able to reproduce this bug on Aries. You have to rotate the screen several times for it to repro. Also seems to be related to Hardware Composer. If I turn off this feature the bug is no longer reproducible.

Video demonstrating the issue:
https://www.youtube.com/watch?v=KNz_1G_8CnA

Also attaching a logcat.

Device: Aries (RC4 > OTA'ed)
BuildID: 20150702032322
Gaia: b901c8b7be2119f4df42781aac1401ed12765460
Gecko: f5e3bacfb60e
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5 Master) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

----

The bug is NOT reproducible on Flame central with HWC enabled.

Device: Flame 2.5
BuildID: 20150702010204
Gaia: b901c8b7be2119f4df42781aac1401ed12765460
Gecko: f5e3bacfb60e
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 42.0a1 (2.5) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Comment 5

[Pi Wei Cheng [:piwei] (inactive)]

NI reporter to confirm whether bug is still reproducible if Hardware Composer in developer settings is disabled.

Comment 6

[Dale Harvey (:daleharvey)]

I cant reproduce this with hardware composer enabled or ddisabled on current builds

Comment 7

[Sotaro Ikeda [:sotaro]]

daleharvey, what is "ddisabled"?

Comment 8

[Dale Harvey (:daleharvey)]

It was just a typo, I meant 'disabled'

Comment 9

[Sotaro Ikeda [:sotaro]]

I succeeded to reproduce the problem on latest master with hwc enabled. I created the rom by myself from source.

Comment 10

[Sotaro Ikeda [:sotaro]]

When the problem happens, the color layers seems not rendered correctly by hwc. But hwc hal seems to pass correct hwc layers info to kernel.

Comment 11

[Sotaro Ikeda [:sotaro]]

In my case, when the problem happen, before rotation start, display is always rotated 180 degree.

Comment 12

[Sotaro Ikeda [:sotaro]]

color layer rendering setting is done by mdss_mdp_pipe_solidfill_setup(). It seems to set correct color to registers. But rendering result is incorrect in the STR. From it, it seems that another registers setting seems missing, because mdss_mdp_pipe_solidfill_setup() is called from mdss_mdp_pipe_queue_data() and color layer rendering register setting route is short cut than other rendering route.

https://github.com/mozilla-b2g/codeaurora_kernel_msm/blob/shinano/drivers/video/msm/mdss/mdss_mdp_pipe.c#L1109

Comment 13

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #11)
> In my case, when the problem happen, before rotation start, display is
> always rotated 180 degree.

From it, the bug might be related to src rotation setting register.

Comment 14

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Set MDSS_MDP_REG_SSPP_SRC_OP_MODE for color layer rendering

The patch seems to fix the problem on my aries device.

Comment 15

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8630141 [details] [diff] [review]
patch - Set MDSS_MDP_REG_SSPP_SRC_OP_MODE for color layer rendering

Diego, sushil, do you know if the bug's problem is fixed on latest codeaurora? aries is xperia Z3C(msm8974) and it does not have official caf support. But the bug seems general platform problem.

Comment 16

[Diego Wilson [:diego]]

(In reply to Sotaro Ikeda [:sotaro] from comment #15)
> Comment on attachment 8630141 [details] [diff] [review]
> patch - Set MDSS_MDP_REG_SSPP_SRC_OP_MODE for color layer rendering
> 
> Diego, sushil, do you know if the bug's problem is fixed on latest
> codeaurora? aries is xperia Z3C(msm8974) and it does not have official caf
> support. But the bug seems general platform problem.

My guess is this issue is specific to msm8974, the color layer implementation is particularly target sensitive.

Comment 17

[Sotaro Ikeda [:sotaro]]

> > Diego, sushil, do you know if the bug's problem is fixed on latest
> > codeaurora? aries is xperia Z3C(msm8974) and it does not have official caf
> > support. But the bug seems general platform problem.
> 
> My guess is this issue is specific to msm8974, the color layer
> implementation is particularly target sensitive.

Thanks!

Comment 18

[Diego Wilson [:diego]]

Comment on attachment 8630141 [details] [diff] [review]
patch - Set MDSS_MDP_REG_SSPP_SRC_OP_MODE for color layer rendering

Review of attachment 8630141 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not very familiar with this kernel driver so removing f?

Comment 19

[Sotaro Ikeda [:sotaro]]

Bug 1176301 also seems to be caused by similar reason. color layer's rendering path seems to lack updating scaling related necessary registers.

Comment 20

[Sotaro Ikeda [:sotaro]]

Attachment: https://github.com/mozilla-b2g/codeaurora_kernel_msm/pull/38

Comment 21

[Michael Wu [:mwu]]

Comment on attachment 8633753 [details] [review]
https://github.com/mozilla-b2g/codeaurora_kernel_msm/pull/38

Rubberstamp.

Comment 22

[Sotaro Ikeda [:sotaro]]

When we get feedback from codeaurora, we might update the fix.
 https://github.com/mozilla-b2g/codeaurora_kernel_msm/commit/4ddd2a35d02ba02b86d92263d590f5332450aff1

Comment 23

[Sotaro Ikeda [:sotaro]]

From the following, mdss_mdp_pipe_solidfill_setup() set MDSS_MDP_REG_SSPP_SRC_OP_MODE. The problem seems to be fixed on sony-aosp-l.
https://github.com/mozilla-b2g/codeaurora_kernel_msm/blob/sony-aosp-l/drivers/video/msm/mdss/mdss_mdp_pipe.c#L1677