1160883 - (Frisian-WordPrediction) Add Frisian (fy or fy-NL) wordlist/dictionary

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Wim]

This is a request to add Frisian wordlist/dictionary to Firefox OS.
The XML-file made by Kevin Scannell is attached.

Comment 1

[Wim]

Attachment: fy.zip

Zipped version of the xml-file

Comment 2

[Wim]

What is the way to process this request? 
Is there something I can do myself, like xml to dict with Python?

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

Hey Wim! I'll need info Kevin as I'm sure he has some tips :) thanks!

Comment 4

[Kevin Scannell]

For the other dictionaries I've done, someone else has always landed the patch on github... not sure about the process.

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

Let's see if Rudy can help with this?

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

We would need to get a keyboard layout implemented first, and then we could add the dictionary.
Could anyone on this provide a ref. to the keyboard layout we want for Frisian language?

If not, I'll try to find one from Android or other sources.

Comment 7

[Wim]

Hi Rudy, you mean the one mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1153136 ?

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yes, thanks for bringing this up.
Let's mark the dependency and I am going to take a look at that patch.

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] RudyLu:keyboard/Bug1153136-Add_Frisian_layout > mozilla-b2g:master

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8611158 [details] [review]
[gaia] RudyLu:keyboard/Bug1153136-Add_Frisian_layout > mozilla-b2g:master

The layout and the dictionary are ready.

Tim, could you help review this?

Wim, if possible, please help take a look if the layout/dictionary is ok.

Thanks.

Comment 11

[Wim]

Hello Rudy Lu,

Thank you for all your hard work, really awesome!

I took the Dutch keyboard from github https://github.com/janjongboom/fxos-dutch-keyboard,
hacked it to the Frisian version and pushed it with WebIDE to my Flame.
And it works, both the wordsuggestions as well as the special characters.

If Tim agrees this bug and https://bugzilla.mozilla.org/show_bug.cgi?id=1153136 can be closed.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8611158 [details] [review]
[gaia] RudyLu:keyboard/Bug1153136-Add_Frisian_layout > mozilla-b2g:master

The dict need to be on the CDN too.

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: pr to update the CDN

Hi Benson,

Could you please help review this, adding a new dictionary to our CDN?
Thanks.

Comment 14

[Benson Wong [:mostlygeek]]

Comment on attachment 8612685 [details] [review]
pr to update the CDN

Looks good. Merged

Comment 15

[Benson Wong [:mostlygeek]]

Shall I deploy this to the CDN?

Comment 16

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Benson,

Yes, please.
Thanks a lot for your help.

Comment 17

[Wim]

Comment on attachment 8611158 [details] [review]
[gaia] RudyLu:keyboard/Bug1153136-Add_Frisian_layout > mozilla-b2g:master

File looks good.

Comment 18

[Benson Wong [:mostlygeek]]

CDN has been updated with the new files.

Comment 19

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Benson, thanks.

Let's try to merge this.

Comment 20

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#ztZnQQTDTUStQsfEvWmf7g

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 21

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/b6c5fda821dce99babf8b9d5799a95eb4aeca64a

Comment 22

[Delphine Lebédel [:delphine - Use needinfo]]

Josh: once more this is a locale that was 100% completed and tested on 2.2, and that we can sign-off on l10n side if they get the autocorrection in. Since this is minimal risk patch, can we get an approval to land on 2.2?

Comment 23

[Josh Cheng [:josh]]

Hi Rudy,
Can you raise 2.2 Uplift approval? Thanks!

Comment 24

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch for v2.2

Comment 25

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8626498 [details] [review]
Patch for v2.2

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): New feature, a new keyboard layout
[User impact] if declined: The native Frisian user would not have keyboard to input.
[Testing completed]: Yes, manually
[Risk to taking this patch] (and alternatives if risky): Low, the newly added keyboard layout won't be enabled if not explicitly specified.
[String changes made]: N/A

Comment 26

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/eca074ebbf65086c82df28c3765da3ad8d24309b