Closed Bug 1160899 Opened 4 years ago Closed 4 years ago

Remove unused mozharness code to query for previous build id

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
Tracking Status
firefox44 --- fixed

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch WiP - v1 (obsolete) β€” β€” Splinter Review
Getting previous build ids uses |find previous -maxdepth 4 -type f -name application.ini| in both mozharness and toolkit. This has been working fine, but we have hit a situation where another application.ini is found.

-maxdepth 4 was likely chosen because on mac the path is previous/XXX.app/Contents/Resources/application.ini, but on windows and linux this would also find previous/distribution/extensions/{...}/application.ini

I have two patches that fix it, but they obviously need to go through some testing instance. I know I can push to try with my own mozharness repo, but afaik try doesn't generate partials and hence wouldn't trigger the code to find the previous application.ini.

If someone can tell me how to test it, I can move forward. I'm attaching the WiP patch, completely untested.
Jordan, can you give me a hint here?
Flags: needinfo?(jlund)
Turns out the code that did this is now unused, morphing this bug to remove the unused code.
Flags: needinfo?(jlund)
Summary: Getting previous buildid for partials generation may find too many application.inis → Remove unused mozharness code to query for previous build id
Attached patch Fix - v1 β€” β€” Splinter Review
Attachment #8600721 - Attachment is obsolete: true
Attachment #8673806 - Flags: review?(jlund)
Comment on attachment 8673806 [details] [diff] [review]
Fix - v1

Review of attachment 8673806 [details] [diff] [review]:
-----------------------------------------------------------------

thanks
Attachment #8673806 - Flags: review?(jlund) → review+
https://hg.mozilla.org/mozilla-central/rev/bbea1ed9586a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.