1160980 - Service.request('getDeviceMemory') resolves to 0 upon boot.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Saw following message in the newly flashed Flame from m-c. qawanted for v2.2.

"InputWindowManager: totalMemory is 0" "
    at iwm_makeInputWindow (app://system.gaiamobile.org/gaia_build_defer_index.js:928:339)"

Alternative way to verify: do |adb shell b2g-info| and see if there is a keyboard process.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The cause of the bug is bug 1150423 and is not in the 2.2 build.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] timdream:system-feature-mem > mozilla-b2g:master

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8600817 [details] [review]
[gaia] timdream:system-feature-mem > mozilla-b2g:master

There are two way to fix this, but the second one will be blocked by bug 1094759.

1) This fix.
2) Return the promise of _getDeviceMemory() in _start() so bootstrap can only continue until it resolves.

I don't know if that fix this actually and I don't know if we should block boot for that one call, so I ended up not to try (2).

I don't know if any other methods wrapped in Services.request calls is affect by bug like this. We should really be careful and not to create start-up data race like the exact bug here in FeatureDetector.

Thanks!

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8600817 [details] [review]
[gaia] timdream:system-feature-mem > mozilla-b2g:master

\O/

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/0b5274f6b5e83db4ab173efeaeb23625af2379c0