1161089 - Handling an autotheme WebActivity while a theme is selected will wrongly add the palette to this theme

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Theme Editor, defect, P1)

Description

[Etienne Segonzac (:etienne)]

There's a bit of Navigation cleanup to do to fix this properly.

+ Add a Navigation.popToRoot() to the Navigation
+ Call Navigation.popToRoot() in the ActivityHandler when we start
+ In Navigation#pop, dispatch a `willhide` event on the panel before poping it
+ in Detail, remove the `AutoTheme:palette` event listener when we get the `willhide` CustomEvent

Comment 1

[Etienne Segonzac (:etienne)]

I'll take this one.

Comment 2

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

Hope you'll like it :)

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 8601592 [details] [review]
Gaia PR

Some nits but especially popToRoot is not working properly :)
Also I don't know what the CSS change is for.

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 8601592 [details] [review]
Gaia PR

Thanks for the review! Updated!

Comment 5

[Julien Wajsberg [:julienw]]

Comment on attachment 8601592 [details] [review]
Gaia PR

r=me, let's land this.

For posterity, here is my alternate implementation for popToRoot:

  popToRoot: function() {
    var currentLength = stack.length;
    var pops = [];
    for (var i = 0; i < currentLength - 1; i++) {
      pops.push(this.pop());
    }
    return Promise.all(pops).then(() => {});
  }

If we ever want to go that path, we'll need to take care we correctly handle possible missing transition events.

Comment 6

[Etienne Segonzac (:etienne)]

Whoops, this landed a while ago
https://github.com/fxos/studio/commit/bc5729d15c990ec773aacf8534387c423f85e170