Closed
Bug 1161100
Opened 9 years ago
Closed 9 years ago
"Make your own theme" should be replace by a "+" button in the Main panel's Header
Categories
(Firefox OS Graveyard :: Gaia::Theme Editor, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: etienne, Assigned: hub, Mentored)
References
Details
(Whiteboard: [lang=js])
Attachments
(1 file)
|
Reporter | |
Updated•9 years ago
|
Mentor: etienne
Whiteboard: [lang=js]
|
|
Reporter | |
Updated•9 years ago
|
Blocks: spark-theme-editor
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8603419 -
Flags: review?(etienne)
|
|
Reporter | |
Comment 3•9 years ago
|
||
Comment on attachment 8603419 [details] [review] Link to Github pull-request: https://github.com/fxos/studio/pull/8 Sweet :) One issue: I think our version of gaia-header is outdated and doesn't support title-end. The optimization is not a big deal but the title is not centered :/ Let's go ahead and update to gaia-header#master as part of this patch (the bower components are currently checked in the repo...). Also, one tiny nit: let's change the title to "Studio", short and simple ;)
Attachment #8603419 -
Flags: review?(etienne)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8603419 [details] [review] Link to Github pull-request: https://github.com/fxos/studio/pull/8 Updated gaia-header and dependencies.
Attachment #8603419 -
Flags: review?(etienne)
|
|
Reporter | |
Comment 5•9 years ago
|
||
Comment on attachment 8603419 [details] [review] Link to Github pull-request: https://github.com/fxos/studio/pull/8 cool :)
Attachment #8603419 -
Flags: review?(etienne) → review+
|
|
Reporter | |
Comment 6•9 years ago
|
||
https://github.com/fxos/studio/commit/95f54ae0e010595422615ee176b56f5e06edfc8c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•