Closed Bug 1161101 Opened 5 years ago Closed 5 years ago
_Get Own Property Descriptor in dom/bindings
Two different unrelated changes here. 1. DOMProxyHandler::set currently uses JS_GetPropertyDescriptor on the prototype, when it doesn't find an own property-descripton. The patch in Bug 1130537 totally changed the algorithm of js::SetPropertyIgnoringNamedGetter and now this functions wants an own property-descriptor only. If that property-descriptor is undefined the function will instead walk the proto chain. 2. CGDOMJSProxyHandler_getOwnPropDescriptor currently uses JS_GetPropertyDescriptorById on the expando, but expandos have no prototype.
Comment on attachment 8600958 [details] [diff] [review] v1 r=me since I've thought this through already.
Attachment #8600958 - Flags: review?(peterv) → review+
Apparently this was a 3.17% win on Tp5 Optimized. http://graphs.mozilla.org/graph.html#tests=[[255,131,35]]&sel=1430680525000,1430853325000&displayrange=7&datatype=geo
That sounds very highly super unlikely.....
You need to log in before you can comment on or make changes to this bug.