Closed
Bug 1161101
Opened 9 years ago
Closed 9 years ago
Use JS_GetOwnPropertyDescriptor in dom/bindings
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.51 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Two different unrelated changes here. 1. DOMProxyHandler::set currently uses JS_GetPropertyDescriptor on the prototype, when it doesn't find an own property-descripton. The patch in Bug 1130537 totally changed the algorithm of js::SetPropertyIgnoringNamedGetter and now this functions wants an own property-descriptor only. If that property-descriptor is undefined the function will instead walk the proto chain. 2. CGDOMJSProxyHandler_getOwnPropDescriptor currently uses JS_GetPropertyDescriptorById on the expando, but expandos have no prototype.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → evilpies
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8600958 -
Flags: review?(peterv)
Comment 2•9 years ago
|
||
Comment on attachment 8600958 [details] [diff] [review] v1 r=me since I've thought this through already.
Attachment #8600958 -
Flags: review?(peterv) → review+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1a33c4ca043c
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee | ||
Comment 5•9 years ago
|
||
Apparently this was a 3.17% win on Tp5 Optimized. http://graphs.mozilla.org/graph.html#tests=[[255,131,35]]&sel=1430680525000,1430853325000&displayrange=7&datatype=geo
Comment 6•9 years ago
|
||
That sounds very highly super unlikely.....
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•