Closed Bug 1161101 Opened 5 years ago Closed 5 years ago

Use JS_GetOwnPropertyDescriptor in dom/bindings

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Two different unrelated changes here.
1. DOMProxyHandler::set currently uses JS_GetPropertyDescriptor on the prototype, when it doesn't find an own property-descripton. The patch in Bug 1130537 totally changed the algorithm of js::SetPropertyIgnoringNamedGetter and now this functions wants an own property-descriptor only. If that property-descriptor is undefined the function will instead walk the proto chain.
2. CGDOMJSProxyHandler_getOwnPropDescriptor currently uses JS_GetPropertyDescriptorById on the expando, but expandos have no prototype.
Assignee: nobody → evilpies
Attached patch v1Splinter Review
Attachment #8600958 - Flags: review?(peterv)
Comment on attachment 8600958 [details] [diff] [review]
v1

r=me since I've thought this through already.
Attachment #8600958 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/1a33c4ca043c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
That sounds very highly super unlikely.....
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.