Add a confirmation prompt when removing a theme

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: etienne, Assigned: hub, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=js])

Attachments

(1 attachment)

(Reporter)

Updated

3 years ago
Blocks: 1133768
(Reporter)

Updated

3 years ago
Mentor: etienne
Whiteboard: [lang=js]
(Assignee)

Comment 1

3 years ago
taking this
Assignee: nobody → hub
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8603389 [details] [review]
Link to Github pull-request: https://github.com/fxos/studio/pull/7
Attachment #8603389 - Flags: review?(etienne)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8603389 [details] [review]
Link to Github pull-request: https://github.com/fxos/studio/pull/7

Cancelling review for now. I need to address a few things first. Will update the PR and re-request.
Attachment #8603389 - Flags: review?(etienne)
(Assignee)

Updated

3 years ago
Attachment #8603389 - Flags: review?(etienne)
(Reporter)

Comment 4

3 years ago
Comment on attachment 8603389 [details] [review]
Link to Github pull-request: https://github.com/fxos/studio/pull/7

Thanks!
r=me with nits
Attachment #8603389 - Flags: review?(etienne) → review+
(Assignee)

Comment 5

3 years ago
addressed the nit. Rebase too for easy landing.
(Assignee)

Comment 6

3 years ago
Merged

https://github.com/fxos/studio/commit/694ea0b820c689bca562946a27ca903112a8e8bf
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.