Closed Bug 1161132 Opened 5 years ago Closed 5 years ago

Allow user resizing for console.dir output

Categories

(DevTools :: Console, defect, P2)

40 Branch
defect

Tracking

(firefox40 fixed)

RESOLVED FIXED
Firefox 40
Tracking Status
firefox40 --- fixed

People

(Reporter: jfong, Assigned: jfong)

References

Details

(Whiteboard: [polish-backlog])

Attachments

(1 file)

We need a way to vertically resize the console.dir output for larger screens.
Should we add devedition-40 whiteboard info to this bug?
Flags: needinfo?(jgriffiths)
For some background, we removed the attempt to resize this based on the current window height (which didn't always work) in Bug 1157944 (see Comment 8 - Comment 12).  We discussed being able to allow user resizing of this output (sort of like how you can resize textareas).
Depends on: 1157944
Summary: Fix CSS for console.dir output → Allow user resizing for console.dir output
(In reply to Jen Fong-Adwent [:ednapiranha] from comment #1)
> Should we add devedition-40 whiteboard info to this bug?

Still got a week to go, why not!
Flags: needinfo?(jgriffiths)
Whiteboard: [devedition-40]
Priority: -- → P2
Attached patch Bug1161132.patchSplinter Review
Setting the min-height to 200px instead of 100px fixes the scroll situation where the top or bottom of the iframe cuts off during vertical resize. Let me know if you think anything else needs to be adjusted or we're good to go.
Attachment #8602867 - Flags: review?(bgrinstead)
Comment on attachment 8602867 [details] [diff] [review]
Bug1161132.patch

Review of attachment 8602867 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8602867 - Flags: review?(bgrinstead) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/90bfa486922a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Whiteboard: [devedition-40] → [polish-backlog]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.