JsepSessionImpl does not remove mid from bundle group when rejecting an m-section in some cases

RESOLVED FIXED in Firefox 40

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bwc, Assigned: bwc)

Tracking

Trunk
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The key problem here is that the code that disables an m-section relies on the mid being present so it knows which mid to remove from the bundle group, but in some cases we decide to disable an m-section before this is copied over.
Posted file MozReview Request: bz://1161136/bwc (obsolete) —
/r/8103 - Bug 1161136: (WIP, needs a test-case) Ensure that mid is copied over before we disable answer m-sections.

Pull down this commit:

hg pull -r 771b306ae999bdf75b93d6c117abeb82364dc96e https://reviewboard-hg.mozilla.org/gecko/
This seems to only happen when the offer has a disabled m-section with an mid that appears in the bundle group, which isn't exactly valid. However, future standardization could create things similar to a=bundle-only that we don't support, which means we probably should remove these mids from the bundle group just in case.
Assignee: nobody → docfaraday
Comment on attachment 8601042 [details]
MozReview Request: bz://1161136/bwc

/r/8103 - Bug 1161136: Ensure that mid is copied over before we disable answer m-sections.

Pull down this commit:

hg pull -r 0610a90fd209d5528b6bc7719b953ebba19f6d3e https://reviewboard-hg.mozilla.org/gecko/
Duplicate of this bug: 1161485
Comment on attachment 8601042 [details]
MozReview Request: bz://1161136/bwc

https://treeherder.mozilla.org/#/jobs?repo=try&revision=26305242e775
Attachment #8601042 - Flags: review?(rjesup)
Comment on attachment 8601042 [details]
MozReview Request: bz://1161136/bwc

Grrr  reviewboard
Attachment #8601042 - Flags: review?(rjesup) → review+
Check back on try push.
Flags: needinfo?(docfaraday)
Flags: needinfo?(docfaraday)
https://hg.mozilla.org/mozilla-central/rev/020d3722b3ff
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Attachment #8601042 - Attachment is obsolete: true
Attachment #8620224 - Flags: review+
You need to log in before you can comment on or make changes to this bug.