Closed
Bug 1161136
Opened 9 years ago
Closed 9 years ago
JsepSessionImpl does not remove mid from bundle group when rejecting an m-section in some cases
Categories
(Core :: WebRTC: Signaling, defect)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
References
Details
Attachments
(1 file, 1 obsolete file)
The key problem here is that the code that disables an m-section relies on the mid being present so it knows which mid to remove from the bundle group, but in some cases we decide to disable an m-section before this is copied over.
Assignee | ||
Comment 1•9 years ago
|
||
/r/8103 - Bug 1161136: (WIP, needs a test-case) Ensure that mid is copied over before we disable answer m-sections. Pull down this commit: hg pull -r 771b306ae999bdf75b93d6c117abeb82364dc96e https://reviewboard-hg.mozilla.org/gecko/
Assignee | ||
Comment 2•9 years ago
|
||
This seems to only happen when the offer has a disabled m-section with an mid that appears in the bundle group, which isn't exactly valid. However, future standardization could create things similar to a=bundle-only that we don't support, which means we probably should remove these mids from the bundle group just in case.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → docfaraday
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8601042 [details] MozReview Request: bz://1161136/bwc /r/8103 - Bug 1161136: Ensure that mid is copied over before we disable answer m-sections. Pull down this commit: hg pull -r 0610a90fd209d5528b6bc7719b953ebba19f6d3e https://reviewboard-hg.mozilla.org/gecko/
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8601042 [details] MozReview Request: bz://1161136/bwc https://treeherder.mozilla.org/#/jobs?repo=try&revision=26305242e775
Attachment #8601042 -
Flags: review?(rjesup)
Comment 6•9 years ago
|
||
https://reviewboard.mozilla.org/r/8103/#review6933 Ship It!
Comment 7•9 years ago
|
||
Comment on attachment 8601042 [details]
MozReview Request: bz://1161136/bwc
Grrr reviewboard
Attachment #8601042 -
Flags: review?(rjesup) → review+
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(docfaraday)
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/020d3722b3ff
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #8601042 -
Attachment is obsolete: true
Attachment #8620224 -
Flags: review+
Assignee | ||
Comment 12•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•