Closed Bug 1161143 Opened 4 years ago Closed 4 years ago

Remove unused android-resources.mn files from b2g branding

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox40 fixed)

RESOLVED FIXED
2.2 S12 (15may)
Tracking Status
firefox40 --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

Details

Attachments

(1 file, 1 obsolete file)

Seems like this is legacy code that was removed from android in bug 892603. We should also remove it from b2g.
Summary: Remove unused android-resources.mn files from b2g repos → Remove unused android-resources.mn files from b2g branding
Fabrice - could you take a look when you get a chance?

Try run:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=6315eb29dd00
Attachment #8601073 - Flags: review?(fabrice)
Comment on attachment 8601073 [details] [diff] [review]
[gecko-dev] Patch - Remove unused branding files

Review of attachment 8601073 [details] [diff] [review]:
-----------------------------------------------------------------

There are unrelated changes in there...
Attachment #8601073 - Flags: review?(fabrice)
Attachment #8601073 - Attachment is obsolete: true
Comment on attachment 8601205 [details] [diff] [review]
[gecko-dev] Patch - Remove unused branding files

Sorry about that - still learning how to use my gecko toolchain apparantly =/

I attached the wrong patch before, this one is verified to be the correct one :)
Attachment #8601205 - Flags: review?(fabrice)
Attachment #8601205 - Flags: review?(fabrice) → review+
Thanks for the review. Adding checkin-needed to get this landed. Try run is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6315eb29dd00

There are some failures, but they seem unrelated, and things that I saw in other try runs - so I'm guessing they are infra related?
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bdd9a31287d7
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S12 (15may)
You need to log in before you can comment on or make changes to this bug.