1161192 - Implement frequency cap in splice

Status: RESOLVED FIXED

(Content Services Graveyard :: Tiles: Administration Front-End, defect)

Description

[Olivier Yiptong [:oyiptong]]

The frequency cap has two periods: daily and total

Comment 1

[Olivier Yiptong [:oyiptong]]

This will require a change in input schema and in output JSON for the adgroups-enabled data

Comment 2

[Olivier Yiptong [:oyiptong]]

jterry: do we have to have *both* daily and total?

Will it ever be the case that one is needed and the other isn't?
In case none is supplied, do we want default values?

Comment 3

[Ed Lee :Mardak]

Firefox hardcodes some defaults of 3 daily and 10 total if there's no frequency_caps object or missing values.

Comment 4

[Olivier Yiptong [:oyiptong]]

Is it something we want to optimize or is it fixed?

Comment 5

[Ed Lee :Mardak]

We can always override the defaults in Firefox by providing a value, and I believe we do want to optimize those numbers. Being able to upload numbers for these allows us to optimize.

Comment 6

[Olivier Yiptong [:oyiptong]]

Excellent, thank you

Comment 7

[Olivier Yiptong [:oyiptong]]

Can frequency caps also apply to directory tiles for v3-supporting clients?

As implemented right now in Splice, directory tiles are also shipped with frequency caps.

That said, I looked at DirectoryLinksProvider.jsm and saw that frequencies are only updated for suggested tiles:
https://github.com/mozilla/gecko-dev/blob/dd3f1a22f80ffe6da13a1498a5afae6b80150e7e/browser/modules/DirectoryLinksProvider.jsm#L618

That means that directory tiles will not disappear over time. Is that something that we want implemented?

The value seems to be dubious because directory tiles are short-lived anyway.

Comment 8

[Ed Lee :Mardak]

The server can accept and provide caps for directory tiles, but currently Firefox doesn't do anything with them for directory tiles. It's nice to have but the main priority is to get them working for suggested tiles.

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/splice

https://github.com/mozilla/splice/commit/4856907085c80f63dc7300e58c3e86c92c082c33
Bug 1161192 - Implement frequency cap in splice

Squashed commit of the following:

commit 798204391829d1d3d6defdbf179a83123170d73c
Author: Olivier Yiptong <[e-mail]>
Date:   Tue May 12 21:19:02 2015 -0400

    db migrations for postgres and redshift

commit b6db01d57c3128b1822483a802189bd0792e2c79
Author: Olivier Yiptong <[e-mail]>
Date:   Tue May 12 16:05:40 2015 -0400

    add comment in test_ingest for test_distribute_frequency_cap

commit 55522b569bd451cc30ab5407034c084674ddec92
Merge: faa97a4 9797760
Author: Olivier Yiptong <[e-mail]>
Date:   Tue May 12 15:31:25 2015 -0400

    Merge branch 'master' into bug_1161192_implement_frequency_cap

commit faa97a4f59a366f4509434845d2d79674cebd96d
Author: Olivier Yiptong <[e-mail]>
Date:   Tue May 12 11:00:08 2015 -0400

    PEP8 fix to splice/ingest.py

commit 2c2d6de7f8d47b34253c2154bcb9d9b7e3bd815d
Author: Olivier Yiptong <[e-mail]>
Date:   Tue May 12 10:56:52 2015 -0400

    make sure legacy tiles do not have frequency caps

commit e16295a6ce5ee1b40dee8a4543444e2019f097b9
Author: Olivier Yiptong <[e-mail]>
Date:   Mon May 11 13:22:21 2015 -0400

    fix PEP8 in tests/test_ingest.py

commit 7c8da0a264dbf7577d7aefdb4cdea05a8145d020
Author: Olivier Yiptong <[e-mail]>
Date:   Mon May 11 13:20:06 2015 -0400

    distribution test and data testing for frequency capping

commit dca0a1f9ddbb53142566c6468d27232a72db73e9
Author: Olivier Yiptong <[e-mail]>
Date:   Thu May 7 15:57:21 2015 -0400

    initial implementation of frequency capping in adgroups

Closes #62
Fix bug 1161192