1161197 - Accept inputs of start/stop times in Splice

Status: RESOLVED FIXED

(Content Services Graveyard :: Tiles: Administration Front-End, defect)

Description

[Olivier Yiptong [:oyiptong]]

Start/Stop times need to be accepted in Splice and output in adgroups-enabled distributions

Comment 1

[Olivier Yiptong [:oyiptong]]

The dates are going to be ISO8061 formatted, with an optional timezone description

Comment 2

[Olivier Yiptong [:oyiptong]]

Will there ever be a need for timezone-unaware start/stop dates?

What I mean to say is:

Will anyone ever want to launch a campaign world-wide at Midnight Jan 1 GMT?
Or is it always Midnight Jan 1, in wherever the country a user is located?

Comment 3

[Ed Lee :Mardak]

ISO8061 allows for optional timezone. If there's no timezone, we have start/stop times in local time, e.g., midnight everywhere. With a timezone, it'll be a simultaneous availability, e.g., 9pm pacific, midnight eastern.

Comment 4

[Olivier Yiptong [:oyiptong]]

Mardak: I'm wondering if we want to take that into consideration. Not allowing absolute times saves us a bit of complexity in the back end.

For instance, should we want to make this string computable, we want to store it as a DateTime object in a database. There is no concept of 'relative' datetimes on the server side.

If we store this as a DateTime column with Timezones, even if the TZ has not been specified, we'd still need a timezone.

If we store this as a DateTime column without Timezones, it makes it a lot easier, but we lose the ability to do both of 'relative' and 'absolute' date times.

We can of course do this either way we want, but we'd just need to write more code to do so. I was just wondering if it was worth bothering with it.

Comment 5

[jterry]

Yes, there will be times when campaigns will need to launch at a specific time, regardless of where the user is located. It's mostly about control of when media's running for the people managing the account.

Comment 6

[Olivier Yiptong [:oyiptong]]

Excellent. We can do both then.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/splice

https://github.com/mozilla/splice/commit/eb32638bc72de6a2dff7b9ee4a141745acebdbe1
Fix Bug 1161197 - Accept inputs of start/stop times in Splice
Closes #71