Accept input of negative adjacency inclusion in Splice

RESOLVED FIXED

Status

Content Services Graveyard
Tiles: Administration Front-End
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: oyiptong, Assigned: oyiptong)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: .002, URL)

(Assignee)

Description

3 years ago
Accept a boolean flag that signifies inclusion in the negative adjacency filter

Updated

3 years ago
Iteration: 40.3 - 11 May → 41.1 - May 25

Comment 1

3 years ago
Looks like the flag will be..

checkInadjacency = true for checking
false or missing for not checking
(Assignee)

Comment 2

3 years ago
in being consistent with the other attributes, can we have it as check_inadjacency ?
(Assignee)

Updated

3 years ago
Assignee: nobody → oyiptong
(Assignee)

Updated

3 years ago

Comment 3

3 years ago
Commit pushed to master at https://github.com/mozilla/splice

https://github.com/mozilla/splice/commit/f32be2bd84fb0fabf400c9c2af4192e303d6ec69
Bug 1161201 - Accept input of negative adjacency inclusion in Splice
Squashed commit of the following:

commit 201bc3196fd821bc03a4a9e5e8346103d85c6e31
Author: Olivier Yiptong <olivier@olivieryiptong.com>
Date:   Tue May 19 17:00:25 2015 -0400

    fix code neatness issue in tests/base.py

commit 04fbbe2075300ba36d3dcdc6300b5f68043d94ab
Author: Olivier Yiptong <olivier@olivieryiptong.com>
Date:   Tue May 19 16:42:22 2015 -0400

    rename check_blacklist to check_inadjacency

commit 2abbbd8c9754987baa8d91764b2721202a36aec1
Author: Olivier Yiptong <olivier@olivieryiptong.com>
Date:   Tue May 19 16:05:58 2015 -0400

    fix tests in SQLite, because it doesn't have 'server defaults'

commit e95b1560134026647799db40ae0e328c39c31539
Author: Olivier Yiptong <olivier@olivieryiptong.com>
Date:   Wed May 13 16:23:12 2015 -0400

    update redshift migration with default values

commit e062975b51d56df1a3715da1b867ef79445ccc6b
Author: Olivier Yiptong <olivier@olivieryiptong.com>
Date:   Wed May 13 16:17:58 2015 -0400

    models and persistence for check_blacklist

commit 0b6be17efbfeb43e2ea2dda074d24ec62def2ede
Author: Olivier Yiptong <olivier@olivieryiptong.com>
Date:   Tue May 12 16:02:38 2015 -0400

    initial implementation of check_blacklist

Fix bug 1161201
Closes #65
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.