1161212 - Keep supporting binary XPCOM components in addons for b2g

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[[:fabrice] Fabrice Desré]

We need that for components shipped by partners. Either a pref or something keyed on MOZ_B2G is fine for me.

Comment 1

[Benjamin Smedberg]

Can you provide details about where partners are shipping these components? Is it only via distribution/bundles or via other mechanisms as well?

Comment 2

[[:fabrice] Fabrice Desré]

They use distribution/bundles

Comment 3

[Benjamin Smedberg]

Attachment: 1144127-distributionbundles

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8601090 [details] [diff] [review]
1144127-distributionbundles

Review of attachment 8601090 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/nsXREDirProvider.cpp
@@ +643,5 @@
>  
>  void
>  nsXREDirProvider::LoadAppBundleDirs()
>  {
> +#ifdef MOZ_B2G

This seems like a really big hammer, and has more effects than just B2G.  Why not conditionalize the constant passed to XRE_AddManifestLocation, below?

Comment 5

[Benjamin Smedberg]

Comment on attachment 8601090 [details] [diff] [review]
1144127-distributionbundles

The policy question of removing distribution/bundle support was handled in bug 1144127 and the remaining issue there was B2G. This patch fixes both problems at the same time.

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8601090 [details] [diff] [review]
1144127-distributionbundles

Review of attachment 8601090 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the change below and the commit message updated to reflect that change.

::: toolkit/xre/nsXREDirProvider.cpp
@@ +667,5 @@
>      mAppBundleDirectories.AppendObject(subdir);
>  
>      nsCOMPtr<nsIFile> manifest =
>        CloneAndAppend(subdir, "chrome.manifest");
> +    XRE_AddManifestLocation(NS_APP_LOCATION, manifest);

Please just pass NS_APP_LOCATION for B2G and NS_EXTENSION_LOCATION everywhere else.  Essentially removing this function on non-B2G is outside the scope of this bug.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e20e099b6df

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2e20e099b6df