Closed
Bug 1161212
Opened 9 years ago
Closed 9 years ago
Keep supporting binary XPCOM components in addons for b2g
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: fabrice, Assigned: benjamin)
References
Details
Attachments
(1 file)
3.37 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
We need that for components shipped by partners. Either a pref or something keyed on MOZ_B2G is fine for me.
Assignee | ||
Comment 1•9 years ago
|
||
Can you provide details about where partners are shipping these components? Is it only via distribution/bundles or via other mechanisms as well?
Flags: needinfo?(fabrice)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8601090 -
Flags: review?(nfroyd)
Comment 4•9 years ago
|
||
Comment on attachment 8601090 [details] [diff] [review] 1144127-distributionbundles Review of attachment 8601090 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/xre/nsXREDirProvider.cpp @@ +643,5 @@ > > void > nsXREDirProvider::LoadAppBundleDirs() > { > +#ifdef MOZ_B2G This seems like a really big hammer, and has more effects than just B2G. Why not conditionalize the constant passed to XRE_AddManifestLocation, below?
Attachment #8601090 -
Flags: review?(nfroyd)
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8601090 [details] [diff] [review] 1144127-distributionbundles The policy question of removing distribution/bundle support was handled in bug 1144127 and the remaining issue there was B2G. This patch fixes both problems at the same time.
Attachment #8601090 -
Flags: review?(nfroyd)
Comment 6•9 years ago
|
||
Comment on attachment 8601090 [details] [diff] [review] 1144127-distributionbundles Review of attachment 8601090 [details] [diff] [review]: ----------------------------------------------------------------- r=me with the change below and the commit message updated to reflect that change. ::: toolkit/xre/nsXREDirProvider.cpp @@ +667,5 @@ > mAppBundleDirectories.AppendObject(subdir); > > nsCOMPtr<nsIFile> manifest = > CloneAndAppend(subdir, "chrome.manifest"); > + XRE_AddManifestLocation(NS_APP_LOCATION, manifest); Please just pass NS_APP_LOCATION for B2G and NS_EXTENSION_LOCATION everywhere else. Essentially removing this function on non-B2G is outside the scope of this bug.
Attachment #8601090 -
Flags: review?(nfroyd) → review+
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2e20e099b6df
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•