Closed Bug 1161238 Opened 5 years ago Closed 4 years ago

Remove #ifdef PR_LOGGING and --disable-logging from Gecko

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: bholley, Assigned: erahm)

References

Details

Attachments

(2 files)

See bug 1161186 comment 4. Given that we turn this on in all our official builds, this is all useless cruft.
Attached file PR_LOGGING usage
It looks like there are 883 uses of |PR_LOGGING| in our codebase (excluding NSPR).
Depends on: 1162242
Depends on: 1162247
Depends on: 1162293
Depends on: 1162309
Depends on: 1162336
Depends on: 1162673
Depends on: 1162691
Depends on: 1162740
Depends on: 1162748
Depends on: 1162751
Depends on: 1163192
Depends on: 1163194
Depends on: 1163196
Depends on: 1163198
Depends on: 1163201
Depends on: 1163907
Depends on: 1164556
Depends on: 1164559
Depends on: 1164620
Depends on: 1164622
Blocks: 1162247
No longer depends on: 1162247
Attachment #8605926 - Flags: review?(gps)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment on attachment 8605926 [details] [diff] [review]
Remove --disable-logging

Review of attachment 8605926 [details] [diff] [review]:
-----------------------------------------------------------------

My immediate to this is "why is there still code in configure.in?" Do we not have a global .h file this could go in instead? (I'm not a Gecko hacker.)

But this is good enough for me. We can always do a follow-up if people want to nitpick style.
Attachment #8605926 - Flags: review?(gps) → review+
(In reply to Gregory Szorc [:gps] (PTO until Nov 3) from comment #3)
> Comment on attachment 8605926 [details] [diff] [review]
> Remove --disable-logging
> 
> Review of attachment 8605926 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> My immediate to this is "why is there still code in configure.in?" Do we not
> have a global .h file this could go in instead? (I'm not a Gecko hacker.)
> 
> But this is good enough for me. We can always do a follow-up if people want
> to nitpick style.

I somehow never landed this, I'll rebase and push.
https://hg.mozilla.org/mozilla-central/rev/9b355ec8e76f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.