If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Adjust graphene prefs for MOZ_HORIZON define

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: graphene-larch [horizon][webvr][vrm2])

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

3 years ago
We should set the following prefs:

pref("b2g.default.start_manifest_url", "https://mozvr.github.io/horizon/web/manifest.webapp");
pref("dom.ipc.tabs.disabled", false);
pref("dom.vr.enabled", true);
(Assignee)

Comment 1

3 years ago
Created attachment 8601114 [details] [diff] [review]
[larch] Patch - Adjust prefs for horizon
(Assignee)

Comment 2

3 years ago
Created attachment 8601119 [details] [diff] [review]
[larch] Patch - Adjust prefs for horizon
Attachment #8601114 - Attachment is obsolete: true
(Assignee)

Comment 3

3 years ago
Created attachment 8601157 [details] [diff] [review]
[larch] Patch - Adjust prefs for horizon

New patch to add necessary bits to configure.in.

Fabrice - can you take a look when you get a chance?
Attachment #8601119 - Attachment is obsolete: true
Attachment #8601157 - Flags: review?(fabrice)
Comment on attachment 8601157 [details] [diff] [review]
[larch] Patch - Adjust prefs for horizon

Review of attachment 8601157 [details] [diff] [review]:
-----------------------------------------------------------------

I chatted with vlad and he told me that e10s needs to be disabled for VR. So you need to move pref("dom.ipc.tabs.disabled", ...) with different values in the #ifdef branches.
Attachment #8601157 - Flags: review?(fabrice) → review-
fwiw -- I would use MOZ_WEBVR_HACK or something similar for the #define.  WebVR is enabled/available in general; the only things that will be behind this define are hacks that aren't ready for going in to m-c as-is.  Having the name MOZ_WEBVR makes it seem like the entire feature is behind a pref.  Might be nitpicky, but..
Or rather, we probably want MOZ_HORIZON and MOZ_WEBVR_HACK.  Setting MOZ_HORIZON should turn on MOZ_WEBVR_HACK as well.  That way stuff that's horzion-specific (like the prefs.js changes) can live behind a pref that we'll want to keep around, and the _HACK stuff can get removed as we fix it.  (Or we just use MOZ_HORIZON for everything.)
(Assignee)

Comment 7

3 years ago
Using MOZ_HORIZON for everything seems like a good option to me. I'll re-submit the patch now.
(Assignee)

Comment 8

3 years ago
Created attachment 8601682 [details] [diff] [review]
[larch] Patch - Adjust prefs for horizon
Attachment #8601157 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Summary: Adjust graphene prefs for MOZ_WEBVR define → Adjust graphene prefs for MOZ_HORIZON define
(Assignee)

Comment 9

3 years ago
Comment on attachment 8601682 [details] [diff] [review]
[larch] Patch - Adjust prefs for horizon

Review of attachment 8601682 [details] [diff] [review]:
-----------------------------------------------------------------

Fabrice - I've updated patch to use MOZ_HORIZON and set values of dom.ipc.tabs.disabled. Can you take a look when you get a chance? Thanks!
Attachment #8601682 - Flags: review?(fabrice)
Attachment #8601682 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/projects/larch/rev/383d3b0a6c6d
Whiteboard: [horizon] → graphene-larch [horizon]

Comment 11

3 years ago
If MOZ_HORIZON here just for the prefs?

If so, I think maybe we can do without the prefs:

- instead of dom.ipc.tabs.disabled:true, just do not use remote=true (is that enough?)
- we could set dom.vr.enabled to true in Graphene too.
- start_manifest_url can be specified from the command line.

And if you need a special branding, what about using `--with-branding` in your mozconfig?
(Assignee)

Comment 12

3 years ago
(In reply to Paul Rouget [:paul] from comment #11)
> If MOZ_HORIZON here just for the prefs?
> 
> If so, I think maybe we can do without the prefs:
> 
> - instead of dom.ipc.tabs.disabled:true, just do not use remote=true (is
> that enough?)
> - we could set dom.vr.enabled to true in Graphene too.
> - start_manifest_url can be specified from the command line.

We're going to be doing nightly builds, so we need some way to change the prefs with a build variable. MOZ_HORIZON is also going to be a temporary flag to disable some graphics features and optimizations for VR, so it's something we need to keep around.


> And if you need a special branding, what about using `--with-branding` in
> your mozconfig?

Yup, I'm testing with this locally and we are handling this in bug 1160717 for nightly builds.

Comment 13

3 years ago
ok!
Whiteboard: graphene-larch [horizon] → graphene-larch [horizon][webvr]

Updated

2 years ago
Whiteboard: graphene-larch [horizon][webvr] → graphene-larch [horizon][webvr][vrm2]
(Assignee)

Comment 14

2 years ago
Landed in mozilla-central via bug 1204965.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.