1161241 - Adjust graphene prefs for MOZ_HORIZON define

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Kevin Grandon :kgrandon]

We should set the following prefs:

pref("b2g.default.start_manifest_url", "https://mozvr.github.io/horizon/web/manifest.webapp");
pref("dom.ipc.tabs.disabled", false);
pref("dom.vr.enabled", true);

Comment 1

[Kevin Grandon :kgrandon]

Attachment: [larch] Patch - Adjust prefs for horizon

Comment 2

[Kevin Grandon :kgrandon]

Attachment: [larch] Patch - Adjust prefs for horizon

Comment 3

[Kevin Grandon :kgrandon]

Attachment: [larch] Patch - Adjust prefs for horizon

New patch to add necessary bits to configure.in.

Fabrice - can you take a look when you get a chance?

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 8601157 [details] [diff] [review]
[larch] Patch - Adjust prefs for horizon

Review of attachment 8601157 [details] [diff] [review]:
-----------------------------------------------------------------

I chatted with vlad and he told me that e10s needs to be disabled for VR. So you need to move pref("dom.ipc.tabs.disabled", ...) with different values in the #ifdef branches.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

fwiw -- I would use MOZ_WEBVR_HACK or something similar for the #define.  WebVR is enabled/available in general; the only things that will be behind this define are hacks that aren't ready for going in to m-c as-is.  Having the name MOZ_WEBVR makes it seem like the entire feature is behind a pref.  Might be nitpicky, but..

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Or rather, we probably want MOZ_HORIZON and MOZ_WEBVR_HACK.  Setting MOZ_HORIZON should turn on MOZ_WEBVR_HACK as well.  That way stuff that's horzion-specific (like the prefs.js changes) can live behind a pref that we'll want to keep around, and the _HACK stuff can get removed as we fix it.  (Or we just use MOZ_HORIZON for everything.)

Comment 7

[Kevin Grandon :kgrandon]

Using MOZ_HORIZON for everything seems like a good option to me. I'll re-submit the patch now.

Comment 8

[Kevin Grandon :kgrandon]

Attachment: [larch] Patch - Adjust prefs for horizon

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8601682 [details] [diff] [review]
[larch] Patch - Adjust prefs for horizon

Review of attachment 8601682 [details] [diff] [review]:
-----------------------------------------------------------------

Fabrice - I've updated patch to use MOZ_HORIZON and set values of dom.ipc.tabs.disabled. Can you take a look when you get a chance? Thanks!

Comment 10

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/projects/larch/rev/383d3b0a6c6d

Comment 11

[Paul Rouget [:paul]]

If MOZ_HORIZON here just for the prefs?

If so, I think maybe we can do without the prefs:

- instead of dom.ipc.tabs.disabled:true, just do not use remote=true (is that enough?)
- we could set dom.vr.enabled to true in Graphene too.
- start_manifest_url can be specified from the command line.

And if you need a special branding, what about using `--with-branding` in your mozconfig?

Comment 12

[Kevin Grandon :kgrandon]

(In reply to Paul Rouget [:paul] from comment #11)
> If MOZ_HORIZON here just for the prefs?
> 
> If so, I think maybe we can do without the prefs:
> 
> - instead of dom.ipc.tabs.disabled:true, just do not use remote=true (is
> that enough?)
> - we could set dom.vr.enabled to true in Graphene too.
> - start_manifest_url can be specified from the command line.

We're going to be doing nightly builds, so we need some way to change the prefs with a build variable. MOZ_HORIZON is also going to be a temporary flag to disable some graphics features and optimizations for VR, so it's something we need to keep around.


> And if you need a special branding, what about using `--with-branding` in
> your mozconfig?

Yup, I'm testing with this locally and we are handling this in bug 1160717 for nightly builds.

Comment 13

[Paul Rouget [:paul]]

ok!

Comment 14

[Kevin Grandon :kgrandon]

Landed in mozilla-central via bug 1204965.