1161252 - Make it a simpler task to retrigger a performance job from graphs view

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

It would be handy to be able to have a "retrigger" link in the graph detail view, for when you want more data.

For bonus points, show if a retrigger is already in progress, so people know not to click on the link again unnecessarily.

Comment 1

[MikeLing]

Hi will, Due to all the issues I got about perfherder are nearly closed. So I would like to work on this as my next bug. Could you assign it to me? Thank you :)

Comment 2

[MikeLing]

(In reply to William Lachance (:wlach) from comment #0)

Hi Will,

How could I retrigger a regression? Could I find any document or API describe in somewhere?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

right now we have the ability to trigger a single retrigger via the UI in treeherder.  We could mirror that functionality in the details of a data point.  It is called retriggerJob:
https://github.com/mozilla/treeherder/search?utf8=%E2%9C%93&q=retriggerJob

you can probably find a way to include that.

As we speak there are patches in various review states to give sheriffs the ability to do retriggering tasks (backfill all jobs).  Once these are in, maybe we could extend this to follow suite.  Basically these are pulse messages with job info and the trigger scenario to pulse with a mozci server will listen for and take action.  

The interesting thing in this bug would be the bonus points of displaying pending/running jobs related to this.

I believe we have the suite or jobname associated with the test, if not- we can build a simple map or do some queries to get it.

Comment 4

[William Lachance (:wlach)]

So on thinking about this a bit more, I think it would be best if we not complicate the perfherder UI's with a retriggering interface. Really, that's better done inside treeherder. I propose that we instead do something a little simpler -- just link to the resultset view from the revision inside the perfherder UI. Then a user can just click there and retrigger manually.

Basically instead of linking to things like this (which is pretty useless):

https://hg.mozilla.org/mozilla-inbound/rev/c0afcf6ed324

Link to this instead:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c0afcf6ed324

Some education will have to be done for users to link talos jobs to results in perfherder, but that shouldn't be too bad. We can always revisit this later but I'd rather do something simple at first.

Comment 5

[MikeLing]

Attachment: PR for bug 1161252

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8634590 [details] [review]
PR for bug 1161252

Looks good except one unwanted line deletion. Fix that and we can land this. :)

Comment 7

[MikeLing]

(In reply to William Lachance (:wlach) from comment #6)
> Comment on attachment 8634590 [details] [review]
> PR for bug 1161252
> 
> Looks good except one unwanted line deletion. Fix that and we can land this.
> :)

Done~ ;)

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/324826de3cca19e9835105ab471c59ef66e82556
Bug 1161252 - Make it easier to retrigger jobs from graphs view

Instead of directing to the pushlog, direct to treeherder job view
from which runs can easily be retriggered.

Comment 9

[William Lachance (:wlach)]

We can close this. We should do something similar in the compare view, I'll file a separate bug for that next week.