1161270 - Add origin manifest data to reftest manifests parsed in mozbuild

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

The data we get out of the build system on reftests is rather limited: we only get the top including manifest out of the build system, and the master reftest manifest is the only reftest manifest in a moz.build file, so we attribute every test to this manifest.

If we can get leaf manifests instead of just the root, making bug 1149670 work for reftests should be very straightforward.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: bz://1161270/chmanchester

/r/8201 - Bug 1161270 - Add source manifest to reftest manifest representation in moz.build.

Pull down this commit:

hg pull -r 77d682fb427934dbea21319859284fe979f51c53 https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

https://reviewboard.mozilla.org/r/8199/#review6965

::: layout/tools/reftest/reftest/__init__.py:48
(Diff revision 1)
> +        self.tests = set()

Where can I add a test to for this?

Comment 3

[Chris Manchester (limited bugmail, email directly)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2428d824d28

Comment 4

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/8201/#review7079

This looks good to me. But I'm not sure I have review privileges for the reftest code. You may want to look at file history to verify we're not violating some expectations.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8602159 [details]
MozReview Request: bz://1161270/chmanchester

https://reviewboard.mozilla.org/r/8199/#review7083

Ship It!

Comment 6

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/8199/#review7081

> Where can I add a test to for this?

python/mozbuild/mozbuild/test/test_testing.py ?

Comment 7

[Chris Manchester (limited bugmail, email directly)]

(In reply to Gregory Szorc [:gps] from comment #4)
> https://reviewboard.mozilla.org/r/8201/#review7079
> 
> This looks good to me. But I'm not sure I have review privileges for the
> reftest code. You may want to look at file history to verify we're not
> violating some expectations.

It looks like roc originally reviewed this file. roc, can you please confirm whether gps' review applies here? Thank you!

Comment 8

[Chris Manchester (limited bugmail, email directly)]

(In reply to Chris Manchester [:chmanchester] from comment #7)
> (In reply to Gregory Szorc [:gps] from comment #4)
> > https://reviewboard.mozilla.org/r/8201/#review7079
> > 
> > This looks good to me. But I'm not sure I have review privileges for the
> > reftest code. You may want to look at file history to verify we're not
> > violating some expectations.
> 
> It looks like roc originally reviewed this file. roc, can you please confirm
> whether gps' review applies here? Thank you!

The changes are in layout/tools/reftest/reftest/__init__.py

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://reviewboard.mozilla.org/r/8201/#review7141

Ship It!

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/77c19e3e5a44

Comment 11

[Chris Manchester (limited bugmail, email directly)]

Thanks!

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/77c19e3e5a44

Comment 14

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1161270 - Add source manifest to reftest manifest representation in moz.build.