Closed Bug 1161270 Opened 6 years ago Closed 6 years ago

Add origin manifest data to reftest manifests parsed in mozbuild

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file, 1 obsolete file)

The data we get out of the build system on reftests is rather limited: we only get the top including manifest out of the build system, and the master reftest manifest is the only reftest manifest in a moz.build file, so we attribute every test to this manifest.

If we can get leaf manifests instead of just the root, making bug 1149670 work for reftests should be very straightforward.
/r/8201 - Bug 1161270 - Add source manifest to reftest manifest representation in moz.build.

Pull down this commit:

hg pull -r 77d682fb427934dbea21319859284fe979f51c53 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8602159 - Flags: review?(gps)
https://reviewboard.mozilla.org/r/8199/#review6965

::: layout/tools/reftest/reftest/__init__.py:48
(Diff revision 1)
> +        self.tests = set()

Where can I add a test to for this?
https://reviewboard.mozilla.org/r/8201/#review7079

This looks good to me. But I'm not sure I have review privileges for the reftest code. You may want to look at file history to verify we're not violating some expectations.
Comment on attachment 8602159 [details]
MozReview Request: bz://1161270/chmanchester

https://reviewboard.mozilla.org/r/8199/#review7083

Ship It!
Attachment #8602159 - Flags: review?(gps) → review+
https://reviewboard.mozilla.org/r/8199/#review7081

> Where can I add a test to for this?

python/mozbuild/mozbuild/test/test_testing.py ?
(In reply to Gregory Szorc [:gps] from comment #4)
> https://reviewboard.mozilla.org/r/8201/#review7079
> 
> This looks good to me. But I'm not sure I have review privileges for the
> reftest code. You may want to look at file history to verify we're not
> violating some expectations.

It looks like roc originally reviewed this file. roc, can you please confirm whether gps' review applies here? Thank you!
Flags: needinfo?(roc)
(In reply to Chris Manchester [:chmanchester] from comment #7)
> (In reply to Gregory Szorc [:gps] from comment #4)
> > https://reviewboard.mozilla.org/r/8201/#review7079
> > 
> > This looks good to me. But I'm not sure I have review privileges for the
> > reftest code. You may want to look at file history to verify we're not
> > violating some expectations.
> 
> It looks like roc originally reviewed this file. roc, can you please confirm
> whether gps' review applies here? Thank you!

The changes are in layout/tools/reftest/reftest/__init__.py
Thanks!
Flags: needinfo?(roc)
https://hg.mozilla.org/mozilla-central/rev/77c19e3e5a44
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Attachment #8602159 - Attachment is obsolete: true
Attachment #8620225 - Flags: review+
You need to log in before you can comment on or make changes to this bug.