Closed Bug 1161325 Opened 5 years ago Closed 5 years ago

make nsStyleVariables copy constructor behave more traditionally

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: heycam, Assigned: heycam)

Details

Attachments

(1 file)

Currently the nsStyleVariables copy constructor doesn't actually copy mVariables from its source, because all the times we do invoke the copy constructor, copying mVariables would be a waste of work.  This is non-obvious, so let's make the copy constructor behave normally by copying mVariables, but avoid invoking it in the cases we don't need to.
Attached patch patchSplinter Review
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8601276 - Flags: review?(dbaron)
Comment on attachment 8601276 [details] [diff] [review]
patch

The comment should perhaps also mention that ComputeVariablesData always sets canStoreInRuleTree to false.
Attachment #8601276 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/5e115ea3795c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.