Closed Bug 1161325 Opened 5 years ago Closed 5 years ago
Style Variables copy constructor behave more traditionally
Currently the nsStyleVariables copy constructor doesn't actually copy mVariables from its source, because all the times we do invoke the copy constructor, copying mVariables would be a waste of work. This is non-obvious, so let's make the copy constructor behave normally by copying mVariables, but avoid invoking it in the cases we don't need to.
Helps to have the patch applied: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1a43ca8ddd4
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8601276 - Flags: review?(dbaron)
Comment on attachment 8601276 [details] [diff] [review] patch The comment should perhaps also mention that ComputeVariablesData always sets canStoreInRuleTree to false.
Attachment #8601276 - Flags: review?(dbaron) → review+
You need to log in before you can comment on or make changes to this bug.