Windows installer is not being updated in nightlies

RESOLVED FIXED in Instantbird 44

Status

Instantbird
Other
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: aleth, Assigned: clokep)

Tracking

trunk
Instantbird 44

Details

(Whiteboard: [1.6-blocking])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
"Last modified 2014-11-29."

Comment 1

3 years ago
The nightly Win32 ZIP build has also stopped updating, as of 2015-05-24 05:53.
(Assignee)

Comment 2

3 years ago
(In reply to Andy from comment #1)
> The nightly Win32 ZIP build has also stopped updating, as of 2015-05-24
> 05:53.

That's unrelated, that was the date of the last win32 build. The builder has been offline.
(Assignee)

Comment 3

2 years ago
Created attachment 8664553 [details] [diff] [review]
win-installer.diff
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Attachment #8664553 - Flags: review?(florian)
(Assignee)

Comment 4

2 years ago
I did wonder if we should make this look more like the m-c version of upload files: http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/installer/upload-files.mk#731
(Assignee)

Comment 5

2 years ago
Results of running this (I also commented out rebuilding the files and running the tests):

$ UPLOAD_CMD='echo $(UPLOAD_FILES)' PRE_UPLOAD_CMD='echo pre-upload' POST_UPLOAD_CMD='echo post-upload' mozmake -C obj-i686-pc-mingw32 distribution
mozmake: Entering directory 'c:/Users/clokep/comm-central/obj-i686-pc-mingw32'
#@c:/mozilla-build/mozmake/mozmake MAKE_SYM_STORE_PATH=. SYM_STORE_SOURCE_DIRS='c:/Users/clokep/comm-central/mozilla/mozilla/extensions/purple c:/Users/clokep/comm-central/mozilla/mozilla c:/Users/clokep/comm-central/mozilla' buildsymbols
#@c:/mozilla-build/mozmake/mozmake -C im/installer libs installer
#c:/mozilla-build/mozmake/mozmake xpcshell-tests
c:/mozilla-build/mozmake/mozmake upload
mozmake[1]: Entering directory 'c:/Users/clokep/comm-central/obj-i686-pc-mingw32'
echo pre-upload
pre-upload
echo dist/instantbird-1.6a1pre.en-US.win32.zip dist/instantbird-1.6a1pre.en-US.win32.installer.exe dist/instantbird-1.6a1pre.en-US.win32.txt
dist/instantbird-1.6a1pre.en-US.win32.zip dist/instantbird-1.6a1pre.en-US.win32.installer.exe dist/instantbird-1.6a1pre.en-US.win32.txt
echo post-upload
post-upload
mozmake[1]: Leaving directory 'c:/Users/clokep/comm-central/obj-i686-pc-mingw32'
mozmake: Leaving directory 'c:/Users/clokep/comm-central/obj-i686-pc-mingw32'
(In reply to Patrick Cloke [:clokep] from comment #4)
> I did wonder if we should make this look more like the m-c version of upload
> files:
> http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/installer/
> upload-files.mk#731

Can you be more specific than "look more like the m-c version"?

The reason why we started forking that rule initially was to avoid uploading lots of files that we don't use at all (to save bandwidth and server storage).
Comment on attachment 8664553 [details] [diff] [review]
win-installer.diff

Review of attachment 8664553 [details] [diff] [review]:
-----------------------------------------------------------------

The change looks reasonable (thanks for debugging this!), but the indent is a mess.
Attachment #8664553 - Flags: review?(florian) → feedback+
(Assignee)

Comment 8

2 years ago
(In reply to Florian Quèze [:florian] [:flo] from comment #6)
> (In reply to Patrick Cloke [:clokep] from comment #4)
> > I did wonder if we should make this look more like the m-c version of upload
> > files:
> > http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/installer/
> > upload-files.mk#731
> 
> Can you be more specific than "look more like the m-c version"?
> 
> The reason why we started forking that rule initially was to avoid uploading
> lots of files that we don't use at all (to save bandwidth and server
> storage).

Mostly I meant using QUOTED_WILDCARD and being more explicit instead of using foreach. But that seems a bit silly. Just passing thoughts.

Do you have a suggestion on the indent? I was having trouble coming up with something sane.
(Assignee)

Comment 9

2 years ago
Created attachment 8664788 [details] [diff] [review]
win-installer.diff v2

Fixed indentation as discussed on IRC.

Also removes the (now unused) outer foreach.
Attachment #8664553 - Attachment is obsolete: true
Attachment #8664788 - Flags: review?(florian)
Attachment #8664788 - Flags: review?(florian) → review+
(Assignee)

Comment 10

2 years ago
https://hg.mozilla.org/comm-central/rev/83524f7be688

Once we have a successful upload we can backport this to aurora/beta.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 44
You need to log in before you can comment on or make changes to this bug.