1161333 - Windows installer is not being updated in nightlies

Status: RESOLVED FIXED

(Instantbird Graveyard :: Other, defect)

Description

[aleth [:aleth]]

"Last modified 2014-11-29."

Comment 1

[George K.]

The nightly Win32 ZIP build has also stopped updating, as of 2015-05-24 05:53.

Comment 2

[Patrick Cloke [:clokep]]

(In reply to Andy from comment #1)
> The nightly Win32 ZIP build has also stopped updating, as of 2015-05-24
> 05:53.

That's unrelated, that was the date of the last win32 build. The builder has been offline.

Comment 3

[Patrick Cloke [:clokep]]

Attachment: win-installer.diff

Comment 4

[Patrick Cloke [:clokep]]

I did wonder if we should make this look more like the m-c version of upload files: http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/installer/upload-files.mk#731

Comment 5

[Patrick Cloke [:clokep]]

Results of running this (I also commented out rebuilding the files and running the tests):

$ UPLOAD_CMD='echo $(UPLOAD_FILES)' PRE_UPLOAD_CMD='echo pre-upload' POST_UPLOAD_CMD='echo post-upload' mozmake -C obj-i686-pc-mingw32 distribution
mozmake: Entering directory 'c:/Users/clokep/comm-central/obj-i686-pc-mingw32'
#@c:/mozilla-build/mozmake/mozmake MAKE_SYM_STORE_PATH=. SYM_STORE_SOURCE_DIRS='c:/Users/clokep/comm-central/mozilla/mozilla/extensions/purple c:/Users/clokep/comm-central/mozilla/mozilla c:/Users/clokep/comm-central/mozilla' buildsymbols
#@c:/mozilla-build/mozmake/mozmake -C im/installer libs installer
#c:/mozilla-build/mozmake/mozmake xpcshell-tests
c:/mozilla-build/mozmake/mozmake upload
mozmake[1]: Entering directory 'c:/Users/clokep/comm-central/obj-i686-pc-mingw32'
echo pre-upload
pre-upload
echo dist/instantbird-1.6a1pre.en-US.win32.zip dist/instantbird-1.6a1pre.en-US.win32.installer.exe dist/instantbird-1.6a1pre.en-US.win32.txt
dist/instantbird-1.6a1pre.en-US.win32.zip dist/instantbird-1.6a1pre.en-US.win32.installer.exe dist/instantbird-1.6a1pre.en-US.win32.txt
echo post-upload
post-upload
mozmake[1]: Leaving directory 'c:/Users/clokep/comm-central/obj-i686-pc-mingw32'
mozmake: Leaving directory 'c:/Users/clokep/comm-central/obj-i686-pc-mingw32'

Comment 6

[Florian Quèze [:florian]]

(In reply to Patrick Cloke [:clokep] from comment #4)
> I did wonder if we should make this look more like the m-c version of upload
> files:
> http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/installer/
> upload-files.mk#731

Can you be more specific than "look more like the m-c version"?

The reason why we started forking that rule initially was to avoid uploading lots of files that we don't use at all (to save bandwidth and server storage).

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8664553 [details] [diff] [review]
win-installer.diff

Review of attachment 8664553 [details] [diff] [review]:
-----------------------------------------------------------------

The change looks reasonable (thanks for debugging this!), but the indent is a mess.

Comment 8

[Patrick Cloke [:clokep]]

(In reply to Florian Quèze [:florian] [:flo] from comment #6)
> (In reply to Patrick Cloke [:clokep] from comment #4)
> > I did wonder if we should make this look more like the m-c version of upload
> > files:
> > http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/installer/
> > upload-files.mk#731
> 
> Can you be more specific than "look more like the m-c version"?
> 
> The reason why we started forking that rule initially was to avoid uploading
> lots of files that we don't use at all (to save bandwidth and server
> storage).

Mostly I meant using QUOTED_WILDCARD and being more explicit instead of using foreach. But that seems a bit silly. Just passing thoughts.

Do you have a suggestion on the indent? I was having trouble coming up with something sane.

Comment 9

[Patrick Cloke [:clokep]]

Attachment: win-installer.diff v2

Fixed indentation as discussed on IRC.

Also removes the (now unused) outer foreach.

Comment 10

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/83524f7be688

Once we have a successful upload we can backport this to aurora/beta.