1161370 - restart buttons not functioning on software update dialog

Status: RESOLVED WORKSFORME

(Toolkit :: Application Update, defect)

Description

[chris hofmann]

I think I'm tracking pretty close to latest 38 betas...

the first time I saw this last week I thought it might be a fluke and ignored, but seems it's happened two times now.

After prompted to update I accept the download and updating and after the install happens I get the software update dialog

   "Update ready to install
    The updates will be installed the next time firefox starts.  You can restart now or continue working and install later."

plus the two buttons "Restart Later" and "Restart Firefox"

neither of the buttons are funtional.  Clicking on them gets not response in terms of the buttons getting focus, or intiating the restart, or dismissing the update dialog.

about: tells me...

Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:38.0) Gecko/20100101 Firefox/38.0

Comment 1

[Robert Strong (they/them - no direct email)]

Hmmm... there are tests for the Restart Later button though there isn't for the Restart button since that would terminate tests. I also run this ui periodically (last week) to verify they work and haven't experienced any issues.

Please set the app.update.log preference to true and the devtools.errorconsole.enabled to true. The next time you see this open the error console under tools -> web developer. Paste any messages that start with AUS:UI in this bug.

Comment 2

[chris hofmann]

ok, devtools.errorconsole.enabled set to true and I'll watch on the next update.

One extra bit of information is that I'm running the update with lots of windows and tabs running for a while and there is general, but not severe, perf degradation across all windows.   by not severe I'm meaning that other browser windows can be scrolled, moved around, etc... but response is sometimes sluggish and see the occasional beachball.

I was able to hit the quit button on the the dialog to dismiss, then restarted ok.

Comment 3

[Robert Strong (they/them - no direct email)]

The restart button hands off the request to restart just as other restart code (e.g. the add-ons mgr, Help -> Restart with add-ons disabled, etc.) and shouldn't make any more difference for the app update ui as it does for any of these other places where restarting occurs. Do those restart buttons, menuitems, etc. work for you?

Comment 4

[chris hofmann]

"Firefox | Quit Firefox" worked.  

I'll check "Help | Restart with Addons disabled"  when I get the next update.

Comment 5

[Robert Strong (they/them - no direct email)]

Thanks though quit doesn't use the same code path as restart.

Comment 6

[Robert Strong (they/them - no direct email)]

I just verified restart still works for me so more sleuthing will be needed.

Comment 7

[chris hofmann]

Attachment: Screen shot 2015-05-09 at 4.19.48 PM.png

ok, back to the point where they update was prompted and has progressed to the point where I've been asked to restart.

I checked the error console and I think I saw this message

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/content/updates.js#1808

I tried to copy it, but now its seems like its gone from the log, and the paste didn't work...
maybe I cleared it from the log instead?

Comment 8

[chris hofmann]

but interestingly enough while the buttons on the "restart later/restart now" dialog seemed to be dead

  help | restart with addons disabled
   and the following dialog with options to restart with addons disabled or restart clean

seems to work.

Comment 9

[Robert Strong (they/them - no direct email)]

Interesting. If you did see that message in the error console the code that follows is for all practical purposes the same as in the about dialog. If you see it again try to find that same message in the error console and any messages that seem to be applicable as well as error messages following it and paste them in this bug.

Comment 10

[Robert Strong (they/them - no direct email)]

needinfo for comment #9

Comment 11

[chris hofmann]

I can't explain it but the problem seems to have gone away.