1161372 - [LayerScope] Add EventRegions fields

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Boris Chiou [:boris]]

Event-regions are provided by layout. Add new data fields, EventRegions, into LayerScope as the dumping of layers Tree did, so we can also use LayerScope to debug it.

Reference: 
https://dxr.mozilla.org/mozilla-central/source/gfx/layers/Layers.cpp#1596
https://dxr.mozilla.org/mozilla-central/source/gfx/layers/LayersLogging.cpp#150

Comment 1

[Boris Chiou [:boris]]

Attachment: viewer side rendering

Comment 2

[Boris Chiou [:boris]]

Attachment: Add EventRegions on LayerScope (v1)

Comment 3

[Boris Chiou [:boris]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=39507de9cb6f

Comment 4

[Boris Chiou [:boris]]

Attachment: Add EventRegions on LayerScope (v2)

Fix commit message..

Comment 5

[u480271]

Comment on attachment 8611130 [details] [diff] [review]
Add EventRegions on LayerScope (v1)

Review of attachment 8611130 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/protobuf/LayerScopePacket.pb.cc
@@ +2479,5 @@
>          }
> +        if (input->ExpectTag(162)) goto parse_hitRegion;
> +        break;
> +      }
> +      

Trailing WS is sad. :-(

Comment 6

[Boris Chiou [:boris]]

Comment on attachment 8611130 [details] [diff] [review]
Add EventRegions on LayerScope (v1)

Review of attachment 8611130 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/protobuf/LayerScopePacket.pb.cc
@@ +2479,5 @@
>          }
> +        if (input->ExpectTag(162)) goto parse_hitRegion;
> +        break;
> +      }
> +      

Yes..

Comment 7

[Boris Chiou [:boris]]

Attachment: Viewer side implementaion

Comment 8

[Boris Chiou [:boris]]

(In reply to Boris Chiou [:boris] from comment #3)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=39507de9cb6f

Looks like these testfaileds, exceptions, and busteds are not related to this patch.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4816abbf3942

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4816abbf3942

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4816abbf3942