Closed Bug 1161410 Opened 5 years ago Closed 5 years ago

Rename --tbpl and --tbpl-debug options to --jitflags in jstests and jit-test.


(Core :: JavaScript Engine, defect)

Not set



Tracking Status
firefox39 --- fixed
firefox40 --- fixed
firefox-esr38 --- fixed


(Reporter: arai, Assigned: arai)




(2 files)

Followup bug for bug 1157354.

(In reply to Steve Fink [:sfink, :s:] from bug 1157354 comment #6)
> I'd vote for landing this as-is, then following up with a patch to rename.
> I'm tempted to reuse the obsolete --jitflags. Perhaps --tbpl =>
> --jitflags=all, --tbpl-debug => --jitflags=debug? (Or use --loop-jitflags
> instead of --jitflags?)

--tbpl flag is passed from several scripts.
Prepared 2 patches, one for changing --jitflags itself, and other for using --jitflags from some scripts.

Currently I'm using "--jitflags", it's obsoleted in, and it seems have no meaning in (not yet obsoleted tho). Value is one of "all", "debug", "ion", "none" (ion corresponds to --ion option in if one of --tbpl, --tbpl-debug, or --ion is supplied, it's used instead (maybe we can change the priority?).

Green on try run:
Assignee: nobody → arai.unmht
Attachment #8602124 - Flags: review?(sphink)
Comment on attachment 8602124 [details] [diff] [review]
Part 1: Update --jitflags option in and as a replacement for --tbpl and --tbpl-debug.

Review of attachment 8602124 [details] [diff] [review]:

::: js/src/tests/lib/
@@ +11,5 @@
>  # When run on tbpl, we run each test multiple times with the following
>  # arguments.
> +    'all': [

Very nice!
Attachment #8602124 - Flags: review?(sphink) → review+
Comment on attachment 8602125 [details] [diff] [review]
Part 2: Use --jitflags instead of --tbpl and --tbpl-debug.

Review of attachment 8602125 [details] [diff] [review]:

I had no idea this was set from so many different places.

::: js/src/
@@ +133,5 @@
>  	(cd $(srcdir) && $(PYTHON) $(topsrcdir)/config/;
>  check-jit-test::
>  	$(JITTEST_ASAN_ENV) $(wildcard $(RUN_TEST_PROGRAM)) $(PYTHON) -u $(srcdir)/jit-test/ \
> +	        --no-slow --no-progress --tinderbox --jitflags=all \

Heh. Next we'll be wanting to s/--tinderbox/--format=automation/

Attachment #8602125 - Flags: review?(sphink) → review+
Thank you for reviewing!
for --tinderbox, filed as bug 1162456.
Depends on: 1163020
You need to log in before you can comment on or make changes to this bug.