Closed Bug 1161410 Opened 5 years ago Closed 5 years ago

Rename --tbpl and --tbpl-debug options to --jitflags in jstests and jit-test.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox39 --- fixed
firefox40 --- fixed
firefox-esr38 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(2 files)

Followup bug for bug 1157354.

(In reply to Steve Fink [:sfink, :s:] from bug 1157354 comment #6)
> I'd vote for landing this as-is, then following up with a patch to rename.
> I'm tempted to reuse the obsolete --jitflags. Perhaps --tbpl =>
> --jitflags=all, --tbpl-debug => --jitflags=debug? (Or use --loop-jitflags
> instead of --jitflags?)

--tbpl flag is passed from several scripts.
https://dxr.mozilla.org/mozilla-central/search?q=%22--tbpl%22&case=true
Prepared 2 patches, one for changing --jitflags itself, and other for using --jitflags from some scripts.

Currently I'm using "--jitflags", it's obsoleted in jstests.py, and it seems have no meaning in jit_test.py (not yet obsoleted tho). Value is one of "all", "debug", "ion", "none" (ion corresponds to --ion option in jit_test.py). if one of --tbpl, --tbpl-debug, or --ion is supplied, it's used instead (maybe we can change the priority?).

Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=44ec1515dd1b
Assignee: nobody → arai.unmht
Attachment #8602124 - Flags: review?(sphink)
Comment on attachment 8602124 [details] [diff] [review]
Part 1: Update --jitflags option in jstests.py and jit_test.py as a replacement for --tbpl and --tbpl-debug.

Review of attachment 8602124 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/lib/tests.py
@@ +11,5 @@
>  
>  # When run on tbpl, we run each test multiple times with the following
>  # arguments.
> +JITFLAGS = {
> +    'all': [

Very nice!
Attachment #8602124 - Flags: review?(sphink) → review+
Comment on attachment 8602125 [details] [diff] [review]
Part 2: Use --jitflags instead of --tbpl and --tbpl-debug.

Review of attachment 8602125 [details] [diff] [review]:
-----------------------------------------------------------------

I had no idea this was set from so many different places.

::: js/src/Makefile.in
@@ +133,5 @@
>  	(cd $(srcdir) && $(PYTHON) $(topsrcdir)/config/check_spidermonkey_style.py);
>  
>  check-jit-test::
>  	$(JITTEST_ASAN_ENV) $(wildcard $(RUN_TEST_PROGRAM)) $(PYTHON) -u $(srcdir)/jit-test/jit_test.py \
> +	        --no-slow --no-progress --tinderbox --jitflags=all \

Heh. Next we'll be wanting to s/--tinderbox/--format=automation/

:-)
Attachment #8602125 - Flags: review?(sphink) → review+
Thank you for reviewing!
for --tinderbox, filed as bug 1162456.
Depends on: 1163020
You need to log in before you can comment on or make changes to this bug.