Closed
Bug 1161493
Opened 11 years ago
Closed 8 years ago
responseURL get property for response object in sdk/request
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: cerriun, Unassigned)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20150415140819
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8601434 [details]
GH PR 1960.htm
I mentioned a couple minor changes to make, otherwise it looks good! and very close to ready to land. Thanks!
One more thing I'd like to see is adding more tests for this property include in our existing tests for the request module, but I won't block on this.
Attachment #8601434 -
Flags: feedback+
|
|
||
Updated•11 years ago
|
Priority: -- → P2
|
|
||
Updated•11 years ago
|
Attachment #8601434 -
Flags: review+
|
||
Comment 3•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/4e091f296b68bc20b268b530b2f57ff964572ca9
Merge pull request #1960 from skipme/master
Bug 1161493 - responseURL get property for response object in sdk/request r=erikvold
|
||
Comment 4•8 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•