Closed Bug 1161530 Opened 9 years ago Closed 9 years ago
[Messages][Refactoring] Remove deprecated String
.prototype .contains usages
Hi there, I would like to work on this bug. It would be my first contribution ever, and this seems pretty easy. It it really just as easy as: - replacing 'return a.contains(b);' with 'return a.includes(b);' at line 12, and - replacing 'if (num.contains(filterValue))' with 'if (num.includes(filterValue))' at line 237? I guess I would have to do something similare in the unit tests you mentioned.
(In reply to Piervincenzo Parisi [:PierV] from comment #1) > Hi there, I would like to work on this bug. It would be my first > contribution ever, and this seems pretty easy. > > It it really just as easy as: > - replacing 'return a.contains(b);' with 'return a.includes(b);' at line 12, > and > - replacing 'if (num.contains(filterValue))' with 'if > (num.includes(filterValue))' at line 237? > > I guess I would have to do something similare in the unit tests you > mentioned. Great! Yeah, basically it's - just few places in the code (contacts.js) and few more in unit tests. Since it's your first contribution, I'd encourage you to start from reading . If you have have any questions, you can need info me here or just come to our IRC channel (#gaia-messaging). So assigning bug to you then :) Thanks!  https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/README.md
Assignee: nobody → piervi_parisi
Hey Piervincenzo, Just wanted to check if you're still going to work this bug, it's OK if you don't have time :) It turned out that dupe of this bug was just filed altogether with the patch, so if you haven't started yet we can find another good bug for you :) Thanks and sorry for the noise!
Hi there! I've had some trouble with the Ubuntu machine so actually I didn't exactly started working on this yet; no problem at all, then. We can definitely find something else to work on! ;)
Cool, thanks! You can always use http://www.joshmatthews.net/bugsahoy/ to find bugs that may be interesting for you or ping me directly.
Assignee: piervi_parisi → nobody
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.