Closed
Bug 1161558
Opened 10 years ago
Closed 10 years ago
cleanup some nsIObserver shutdown paths
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: mcmanus, Assigned: mcmanus)
Details
Attachments
(1 file)
|
4.87 KB,
patch
|
bagder
:
review+
|
Details | Diff | Splinter Review |
In httpHandler I noticed that the link topic observer was added as a
strong reference (last arg of addobserver is false), while the
httphandler is actualy setup as a weak object and for that reason
doesn't remove the observers in the shutdown path..
I then looked for other necko addObserver() paths and fixed up a
couple other ones that truly did use strong observers but didn't clean
themselves up.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8601494 -
Flags: review?(daniel)
|
|
Assignee | |
Updated•10 years ago
|
Summary: [PATCH 1/2] cleanup some nsIObserver shutdown paths → cleanup some nsIObserver shutdown paths
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8601494 [details] [diff] [review]
[PATCH 1/2] cleanup some nsIObserver shutdown paths
Review of attachment 8601494 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM!
Attachment #8601494 -
Flags: review?(daniel) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•