cleanup some nsIObserver shutdown paths

RESOLVED FIXED in Firefox 40

Status

()

Core
Networking: HTTP
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mcmanus, Assigned: mcmanus)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
In httpHandler I noticed that the link topic observer was added as a
strong reference (last arg of addobserver is false), while the
httphandler is actualy setup as a weak object and for that reason
doesn't remove the observers in the shutdown path..

I then looked for other necko addObserver() paths and fixed up a
couple other ones that truly did use strong observers but didn't clean
themselves up.
(Assignee)

Comment 1

3 years ago
Created attachment 8601494 [details] [diff] [review]
[PATCH 1/2] cleanup some nsIObserver shutdown paths
Attachment #8601494 - Flags: review?(daniel)
(Assignee)

Updated

3 years ago
Summary: [PATCH 1/2] cleanup some nsIObserver shutdown paths → cleanup some nsIObserver shutdown paths
Comment on attachment 8601494 [details] [diff] [review]
[PATCH 1/2] cleanup some nsIObserver shutdown paths

Review of attachment 8601494 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!
Attachment #8601494 - Flags: review?(daniel) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3befbdc57b4d
https://hg.mozilla.org/mozilla-central/rev/3befbdc57b4d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.