Calendar's app module shouldn't expose things it only needs internally

RESOLVED FIXED

Status

Firefox OS
Gaia::Calendar
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gaye, Assigned: gaye)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Comment hidden (empty)

Comment 1

3 years ago
Created attachment 8601569 [details] [review]
[gaia] gaye:move-more-app-stuff-out-of-app.js > mozilla-b2g:master
Blocks: 1096518
Assignee: nobody → gaye
(Assignee)

Updated

3 years ago
Attachment #8601569 - Flags: review?(mmedeiros)
Comment on attachment 8601569 [details] [review]
[gaia] gaye:move-more-app-stuff-out-of-app.js > mozilla-b2g:master

r+ with minor comments on github. really good work. way easier to understand and moving codebase into the right direction.
Attachment #8601569 - Flags: review?(mmedeiros) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Comment 3

3 years ago
http://docs.taskcluster.net/tools/task-graph-inspector/#P153gpPdTe6Lwd63t41r5Q

The pull request failed to pass integration tests. It could not be landed, please try again.
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Comment 4

3 years ago
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/5fd777b256f79234aa0d44e99fcf3930889beef3

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 5

3 years ago
Created attachment 8603630 [details] [review]
[gaia] gaye:bug-1161598-followup > mozilla-b2g:master
(Assignee)

Comment 6

3 years ago
Comment on attachment 8603630 [details] [review]
[gaia] gaye:bug-1161598-followup > mozilla-b2g:master

r=self small followup
Attachment #8603630 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Comment 7

3 years ago
http://docs.taskcluster.net/tools/task-graph-inspector/#wgHT2XbFRjGzzCn-jJBwOw

The pull request failed to pass integration tests. It could not be landed, please try again.
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Comment 8

3 years ago
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/75ed946d415fe3ebc380ac5382b659c692780733

Comment 9

3 years ago
Created attachment 8603664 [details] [review]
[gaia] gaye:bug-1161598-followup-followup > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8603664 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Comment 10

3 years ago
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/c13ccf68fb7ca44ff91faef6774d3ae116ef3804
You need to log in before you can comment on or make changes to this bug.