Closed
Bug 1161598
Opened 10 years ago
Closed 10 years ago
Calendar's app module shouldn't expose things it only needs internally
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gaye, Assigned: gaye)
References
Details
Attachments
(3 files)
No description provided.
Comment 1•10 years ago
|
||
Updated•10 years ago
|
Assignee: nobody → gaye
Assignee | ||
Updated•10 years ago
|
Attachment #8601569 -
Flags: review?(mmedeiros)
Comment 2•10 years ago
|
||
Comment on attachment 8601569 [details] [review]
[gaia] gaye:move-more-app-stuff-out-of-app.js > mozilla-b2g:master
r+ with minor comments on github. really good work. way easier to understand and moving codebase into the right direction.
Attachment #8601569 -
Flags: review?(mmedeiros) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 3•10 years ago
|
||
http://docs.taskcluster.net/tools/task-graph-inspector/#P153gpPdTe6Lwd63t41r5Q
The pull request failed to pass integration tests. It could not be landed, please try again.
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/5fd777b256f79234aa0d44e99fcf3930889beef3
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 5•10 years ago
|
||
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8603630 [details] [review]
[gaia] gaye:bug-1161598-followup > mozilla-b2g:master
r=self small followup
Attachment #8603630 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 7•10 years ago
|
||
http://docs.taskcluster.net/tools/task-graph-inspector/#wgHT2XbFRjGzzCn-jJBwOw
The pull request failed to pass integration tests. It could not be landed, please try again.
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/75ed946d415fe3ebc380ac5382b659c692780733
Comment 9•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8603664 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 10•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/c13ccf68fb7ca44ff91faef6774d3ae116ef3804
You need to log in
before you can comment on or make changes to this bug.
Description
•