Calendar's app module shouldn't expose things it only needs internally

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gaye, Assigned: gaye)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Comment hidden (empty)
Created attachment 8601569 [details] [review]
[gaia] gaye:move-more-app-stuff-out-of-app.js > mozilla-b2g:master
Assignee: nobody → gaye
(Assignee)

Updated

4 years ago
Attachment #8601569 - Flags: review?(mmedeiros)
Comment on attachment 8601569 [details] [review]
[gaia] gaye:move-more-app-stuff-out-of-app.js > mozilla-b2g:master

r+ with minor comments on github. really good work. way easier to understand and moving codebase into the right direction.
Attachment #8601569 - Flags: review?(mmedeiros) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#P153gpPdTe6Lwd63t41r5Q

The pull request failed to pass integration tests. It could not be landed, please try again.
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Keywords: checkin-needed
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Created attachment 8603630 [details] [review]
[gaia] gaye:bug-1161598-followup > mozilla-b2g:master
Comment on attachment 8603630 [details] [review]
[gaia] gaye:bug-1161598-followup > mozilla-b2g:master

r=self small followup
Attachment #8603630 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#wgHT2XbFRjGzzCn-jJBwOw

The pull request failed to pass integration tests. It could not be landed, please try again.
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Keywords: checkin-needed
Created attachment 8603664 [details] [review]
[gaia] gaye:bug-1161598-followup-followup > mozilla-b2g:master
(Assignee)

Updated

4 years ago
Attachment #8603664 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.