Closed Bug 1161598 Opened 10 years ago Closed 10 years ago

Calendar's app module shouldn't expose things it only needs internally

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gaye, Assigned: gaye)

References

Details

Attachments

(3 files)

[gaia] gaye:move-more-app-stuff-out-of-app.js > mozilla-b2g:master
46 bytes, text/x-github-pull-request
mmedeiros
: review+
Details | Review
[gaia] gaye:bug-1161598-followup > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gaye
: review+
Details | Review
[gaia] gaye:bug-1161598-followup-followup > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gaye
: review+
Details | Review
No description provided.
Assignee: nobody → gaye
Attachment #8601569 - Flags: review?(mmedeiros)
Comment on attachment 8601569 [details] [review] [gaia] gaye:move-more-app-stuff-out-of-app.js > mozilla-b2g:master r+ with minor comments on github. really good work. way easier to understand and moving codebase into the right direction.
Attachment #8601569 - Flags: review?(mmedeiros) → review+
Keywords: checkin-needed
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#P153gpPdTe6Lwd63t41r5Q The pull request failed to pass integration tests. It could not be landed, please try again.
Keywords: checkin-needed
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8603630 [details] [review] [gaia] gaye:bug-1161598-followup > mozilla-b2g:master r=self small followup
Attachment #8603630 - Flags: review+
Keywords: checkin-needed
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#wgHT2XbFRjGzzCn-jJBwOw The pull request failed to pass integration tests. It could not be landed, please try again.
Keywords: checkin-needed
Keywords: checkin-needed
Attachment #8603664 - Flags: review+
Keywords: checkin-needed
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: