|ErrorWrongTypeArg| leaks a heap allocated error string

RESOLVED FIXED in Firefox 40

Status

()

defect
RESOLVED FIXED
4 years ago
Last year

People

(Reporter: erahm, Assigned: arai)

Tracking

(Blocks 1 bug, {coverity})

Trunk
mozilla40
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

(Whiteboard: [CID 1296136][MemShrink:P3])

Attachments

(1 attachment)

Coverity indicates that |ErrorWrongTypeArg| leaks a heap allocated error string returned from |JS_EncodeString| [1].

[1] https://hg.mozilla.org/mozilla-central/annotate/754579ec0e68/js/src/builtin/SIMD.cpp#l81
added null check and JS_free.

Try is running: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b192b8fe297f
Assignee: nobody → arai.unmht
Attachment #8601657 - Flags: review?(benj)
Comment on attachment 8601657 [details] [diff] [review]
Fix leak in ErrorWrongTypeArg.

Review of attachment 8601657 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, looks good!
Attachment #8601657 - Flags: review?(benj) → review+
Whiteboard: [CID 1296136] → [CID 1296136][MemShrink:P3]
https://hg.mozilla.org/mozilla-central/rev/5b06411e7a5b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.