Closed
Bug 1161628
Opened 9 years ago
Closed 9 years ago
|ErrorWrongTypeArg| leaks a heap allocated error string
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: erahm, Assigned: arai)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1296136][MemShrink:P3])
Attachments
(1 file)
1.27 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
Coverity indicates that |ErrorWrongTypeArg| leaks a heap allocated error string returned from |JS_EncodeString| [1]. [1] https://hg.mozilla.org/mozilla-central/annotate/754579ec0e68/js/src/builtin/SIMD.cpp#l81
Assignee | ||
Comment 1•9 years ago
|
||
added null check and JS_free. Try is running: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b192b8fe297f
Assignee: nobody → arai.unmht
Attachment #8601657 -
Flags: review?(benj)
Comment 2•9 years ago
|
||
Comment on attachment 8601657 [details] [diff] [review] Fix leak in ErrorWrongTypeArg. Review of attachment 8601657 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, looks good!
Attachment #8601657 -
Flags: review?(benj) → review+
Reporter | ||
Updated•9 years ago
|
Whiteboard: [CID 1296136] → [CID 1296136][MemShrink:P3]
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5b06411e7a5b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•