Closed Bug 1161628 Opened 5 years ago Closed 5 years ago

|ErrorWrongTypeArg| leaks a heap allocated error string

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: erahm, Assigned: arai)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 1296136][MemShrink:P3])

Attachments

(1 file)

Coverity indicates that |ErrorWrongTypeArg| leaks a heap allocated error string returned from |JS_EncodeString| [1].

[1] https://hg.mozilla.org/mozilla-central/annotate/754579ec0e68/js/src/builtin/SIMD.cpp#l81
added null check and JS_free.

Try is running: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b192b8fe297f
Assignee: nobody → arai.unmht
Attachment #8601657 - Flags: review?(benj)
Comment on attachment 8601657 [details] [diff] [review]
Fix leak in ErrorWrongTypeArg.

Review of attachment 8601657 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, looks good!
Attachment #8601657 - Flags: review?(benj) → review+
Whiteboard: [CID 1296136] → [CID 1296136][MemShrink:P3]
https://hg.mozilla.org/mozilla-central/rev/5b06411e7a5b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.