Closed Bug 1161640 Opened 5 years ago Closed 5 years ago
_read _entire _file| can leak file descriptor (command line build utility)
Coverity reports that |mar_read_entire_file| can leak file descriptor |f| if |fseeko| fails .  https://hg.mozilla.org/mozilla-central/annotate/754579ec0e68/modules/libmar/verify/mar_verify.c#l38
Summary: |mar_read_entire_file| can leak file descriptor → |mar_read_entire_file| can leak file descriptor (command line build utility)
Whiteboard: [CID 1293422] → [CID 1293422][lang=c++][good first bug]
Hello Eric, can I take this bug?
Hi José, thank you for the interest! The bug is available for you to work on, please let me know if you need help getting started.
Eric, here is a first patch of the solution.
Attachment #8602460 - Flags: review?(erahm)
Comment on attachment 8602460 [details] [diff] [review] bug1161640_moving_fclose.patch Thanks and much appreciated! If you'd like to help out some more there is also bug 1161666 and bug 1161686. I'll land this tonight
Attachment #8602460 - Flags: review?(erahm) → review+
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.