Closed Bug 1161661 Opened 5 years ago Closed 5 years ago
Provide progress and state feedback via the stub installer taskbar icon
Patch coming up
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Attachment #8601642 - Flags: review?(spohl.mozilla.bugs)
I'm planning to use this bug to read up on NSIS and its scripting language to speed up reviews in the future. Let me know if this bug is too urgent for that.
Comment on attachment 8601642 [details] [diff] [review] patch rev1 Review of attachment 8601642 [details] [diff] [review]: ----------------------------------------------------------------- I'll take the review in the meantime spohl. Very cool rstrong.
Attachment #8601642 - Flags: review?(spohl.mozilla.bugs) → review+
Target Milestone: --- → Firefox 40
And we only build the stub installer for nightlies, so the only way to find out whether a patch actually works is to land it, get it merged to m-c, and then burn a nightly? Fun! Backed out in https://hg.mozilla.org/mozilla-central/rev/8f21d63b310a for https://treeherder.mozilla.org/logviewer.html#?job_id=1462107&repo=mozilla-central, 06:05:56 INFO - !insertmacro: macro "CallArtificialFunction" already being inserted! 06:05:56 INFO - Error in macro _WinVerAtLeast on macroline 2 06:05:56 INFO - Error in macro _If on macroline 9 06:05:56 INFO - Error in macro ITBL3SetProgressState_ on macroline 2 06:05:56 INFO - Error in macro CallArtificialFunction on macroline 11 06:05:56 INFO - Error in macro ITBL3SetProgressStateCall on macroline 2 06:05:56 INFO - Error in script "stub.nsi" on line 1300 -- aborting creation process
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 40 → ---
I built it locally and this must have ran into a problem when compiling with the old NSIS that I asked to have upgraded / deployed to the build slaves over a year ago in bug 989531
This is in addition to the existing patch. It removes the windows version checks from the ITBL3SetProgressValue and ITBL3SetProgressState macros. These aren't needed since the ITBL3Create macro which doesn't use the CallArtificialFunction macro checks the Windows version and if it isn't compatible with IID_ITaskbarList3 it leaves the $ITaskbarList3 var set to 0.
Attachment #8604443 - Flags: review?(spohl.mozilla.bugs)
I also verified this works with NSIS 2.46 Unicode locally.
Attachment #8604443 - Flags: review?(spohl.mozilla.bugs) → review+
Missed the confvars change in the above try push... trying again https://treeherder.mozilla.org/#/jobs?repo=try&revision=987b874dce19
Try looks good and the stub was built. I'll land later tonight
You need to log in before you can comment on or make changes to this bug.