Closed Bug 1161700 Opened 9 years ago Closed 9 years ago

Flame: rotation during the video playback temporarily shows screen not centered property

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME
Project Flags:
blocking-b2g 2.5?
Tracking Flags:
Tracking Status
b2g-v2.2 --- unaffected
b2g-master --- affected

People

(Reporter: njpark, Assigned: bwu)

References

Details

(Keywords: regression) 

STR:
Open a Video app or Gallery app.
Pick a video, start playing.
While playing, rotate screen.

Actual:
After the rotation, the screen is briefly off center
Expected:
Screen rotates properly without any visual issues.

Version Info:
Build ID               20150505010204
Gaia Revision          70077825aab2c7a79611befb40a5fe7e610d5443
Gaia Date              2015-05-04 18:09:33
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/102d0e9aa9e1
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150505.043622
Firmware Date          Tue May  5 04:36:34 EDT 2015
Bootloader             L1TC000118D0
[Blocking Requested - why for this release]:
Rotation feature displays obvious visual imperfection.

adding qawanted for branch check and regression range check.
blocking-b2g: --- → 3.0?
Keywords: qawanted, regressionwindow-wanted
OS: Unspecified → Gonk (Firefox OS)
Hardware: Unspecified → ARM
QA Contact: ktucker
This looks to have been caused by bug 1155261

Mozilla Inbound

Last Working
Device: Flame 3.0
BuildID: 20150427014358
Gaia: b4c949cdc780893897c9b45c1adea46e2eb694ff
Gecko: 45d82aa2fbb4
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Borken
Environmental Variables:
Device: Flame 3.0
BuildID: 20150427015253
Gaia: b4c949cdc780893897c9b45c1adea46e2eb694ff
Gecko: fe832ef6cc60
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working Gaia First Broken Gecko: Issue DOES reproduce 
Gaia:  b4c949cdc780893897c9b45c1adea46e2eb694ff
Gecko: fe832ef6cc60

First Broken Gaia Last Working Gecko: Issue DOES NOT reproduce
Gaia:  b4c949cdc780893897c9b45c1adea46e2eb694ff
Gecko: 45d82aa2fbb4

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=45d82aa2fbb4&tochange=fe832ef6cc60
Jonathan, can you take a look at this please? This looks to have been caused by the landing for bug 1155261.
Blocks: 1155261
QA Whiteboard: [QAnalyst-Triage+]
status-b2g-v2.2: --- → unaffected
status-b2g-master: --- → affected
Flags: needinfo?(jfkthame)
It seems really surprising that bug 1155261 would cause this, as it should not have had any effect except on text with writing-mode:vertical.

I'll try to reproduce this locally and look into it a bit more, though it may take some time (last time I tried to build for flame -- quite a while back -- I couldn't ever get the build to complete; I forget the details, though).

Can you try a build with bug 1155261 backed out, to see whether that actually makes the problem go away?
Flags: needinfo?(jfkthame)
With a Flame running build id 20150501010203, I can reproduce this some of the time. Playing a video and repeatedly rotating the phone back and forth shows the glitch fairly often but not always; sometimes the transition is "clean".

It looks to me like this may be a timing issue where a couple of properties -- the scale of the video, and its position -- are being transitioned independently, and if one of them gets significantly delayed for some reason, we get the ugly intermediate state with the mis-positioned video. But I don't see any plausible connection to bug 1155261....

Unfortunately, I haven't yet managed to get my local build to complete, so have not been able to experiment further. Maybe someone with a working build could try backing out bug 1155261 to confirm whether that fixes the issue?
Flags: needinfo?(ktucker)
You are correct. We backed out the commit and the issue is still occurring. Sorry for posting the wrong window. Apparently, the reproducibility rate drops. We are getting another window now.
Flags: needinfo?(ktucker)
This issue seems to actually be two issues depending on which app you open it on.  In Gallery, I was able to reproduce this issue on 3.0, 2.2, 2.1, and 2.0 Flame builds which would indicate that it is not a regression.  

In Video however, I was only able to reproduce this issue on 3.0 Flame builds.  I will finish getting the window for the Video app tomorrow.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150507071613
Gaia: 83b27f522642ea573c57e882657ab5c73d4b07f4
Gecko: 403e3c2380b5
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150506174743
Gaia: 83a63e0e6fcc22c6a74b06ef77b88d5049719cad
Gecko: 118ddfc76b60
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Environmental Variables:
Device: Flame 2.1
BuildID: 20150507084645
Gaia: 3e7bd686ecd852f4dfa4605b45f558e6bd34f02a
Gecko: d85173eb5bf4
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Environmental Variables:
Device: Flame 2.0
BuildID: 20150504084302
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: e67ed29e8ad0
Version: 32.0 (2.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
Flags: needinfo?(ktucker)
The changes for Bug 1146729 seem to have caused this issue.  Please see the pushlog.

Mozilla-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 3.0
BuildID: 20150427015253
Gaia: b4c949cdc780893897c9b45c1adea46e2eb694ff
Gecko: fe832ef6cc60
Gonk: Could not pull gonk.  Did you shallow Flash?
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken 
Environmental Variables:
Device: Flame 3.0
BuildID: 20150427020457
Gaia: b4c949cdc780893897c9b45c1adea46e2eb694ff
Gecko: 5fa88d413c4f
Gonk: Could not pull gonk.  Did you shallow Flash?
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working gaia / First Broken gecko - Issue DOES occur
Gaia: b4c949cdc780893897c9b45c1adea46e2eb694ff
Gecko: 5fa88d413c4f

First Broken gaia / Last Working gecko - Issue does NOT occur
Gaia: b4c949cdc780893897c9b45c1adea46e2eb694ff
Gecko: fe832ef6cc60

Gecko Pushlog: 
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=fe832ef6cc60&tochange=5fa88d413c4f
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Looks like I was one build off... 

Blake, can you take a look at this please? Looks like the landing for bug 1146729 might be the cause here.
Blocks: 1146729
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker) → needinfo?(bwu)
I has confirmed this bug is caused due to the landed patch in bug 1146729. 
I will check it.
Assignee: nobody → bwu
Flags: needinfo?(bwu)
Blake, could you comment this? As my test, issue is gone on foxfooding phone (Master).
(In reply to Bobby Chien [:bchien] from comment #11)
> Blake, could you comment this? As my test, issue is gone on foxfooding phone
> (Master).
I cannot see this problem on my foxfooding phone either. There should be no codes specifically changed for this bug. 

njpark,
Would you mind checking again if this problem can be seen on current master code base?
Thanks!
Flags: needinfo?(npark)
The issue is gone on my flame device as well. I should close this bug.  Thanks!
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(npark)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.